Run CI on Windows

Previously, we didn't test lsif-java on Windows resulting in bugs like
#422. This commit adds a
build matrix to our CI job and fixes path escaping logic so that it
should work correctly on Windows.

Author: olafurpg

.github/workflows/ci.yml

@@ -6,10 +6,15 @@ on:
   pull_request:
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on:  ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [windows-latest, ubuntu-latest]
     steps:
       - uses: actions/checkout@v2
-      - uses: olafurpg/setup-scala@v13
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
       - uses: actions/setup-go@v2
         with:
           go-version: "^1.13.1"

lsif-java/src/main/scala/com/sourcegraph/lsif_java/buildtools/GradleBuildTool.scala

@@ -215,7 +215,8 @@ class GradleBuildTool(index: IndexCommand) extends BuildTool("Gradle", index) {
           |    }
           |  }
           |  task $lsifJavaDependencies {
-          |    def depsOut = java.nio.file.Paths.get('$dependenciesPath')
+          |    def depsOut = java.nio.file.Paths.get(
+          |      java.net.URI.create('${dependenciesPath.toUri}'))
           |    doLast {
           |      java.nio.file.Files.createDirectories(depsOut.getParent())
           |      tasks.withType(JavaCompile) {

lsif-java/src/main/scala/com/sourcegraph/lsif_java/buildtools/GradleJavaToolchains.scala

@@ -70,7 +70,8 @@ object GradleJavaToolchains {
       s"""|
           |try {
           |  java.nio.file.Files.write(
-          |    java.nio.file.Paths.get('$gradleVersionPath'),
+          |    java.nio.file.Paths.get(
+          |      java.net.URI.create('${gradleVersionPath.toUri}')),
           |    [gradle.gradleVersion],
           |    java.nio.file.StandardOpenOption.TRUNCATE_EXISTING,
           |    java.nio.file.StandardOpenOption.CREATE)
@@ -88,7 +89,8 @@ object GradleJavaToolchains {
           |
           |allprojects {
           |  task $taskName {
-          |    def toolchainsOut = java.nio.file.Paths.get('$toolchainsPath')
+          |    def toolchainsOut = java.nio.file.Paths.get(
+          |      java.net.URI.create('${toolchainsPath.toUri}'))
           |    doLast {
           |      try {
           |        tasks.withType(JavaCompile) {

project/JavaToolchainPlugin.scala

@@ -92,7 +92,8 @@ object JavaToolchainPlugin extends AutoPlugin {
           .toList
           .flatMap(index => "--jvm-index" :: index :: Nil)
         val arguments =
-          List(coursier.toString, "java-home", "--jvm", v) ++ index
+          List("java", "-jar", coursier.toString, "java-home", "--jvm", v) ++
+            index
         new File(Process(arguments).!!.trim)
       }
     )

tests/buildTools/src/test/scala/tests/BaseBuildToolSuite.scala

@@ -4,6 +4,8 @@ import java.nio.file.FileSystems
 import java.nio.file.Files
 import java.nio.file.Path
 
+import scala.util.Properties
+
 import scala.meta.internal.io.FileIO
 import scala.meta.io.AbsolutePath
 
@@ -12,12 +14,28 @@ import com.sourcegraph.lsif_java.buildtools.ClasspathEntry
 import moped.testkit.DeleteVisitor
 import moped.testkit.FileLayout
 import moped.testkit.MopedSuite
+import munit.Tag
 import munit.TestOptions
 import os.Shellable
 
 abstract class BaseBuildToolSuite extends MopedSuite(LsifJava.app) {
   override def environmentVariables: Map[String, String] = sys.env
 
+  def tags = List.empty[Tag]
+
+  override def munitTestTransforms: List[TestTransform] =
+    super.munitTestTransforms ++
+      List(
+        new TestTransform(
+          "SkipWindows",
+          t =>
+            if (Properties.isWin && t.tags(SkipWindows))
+              t.tag(munit.Ignore)
+            else
+              t
+        )
+      )
+
   // NOTE(olafur): workaround for https://github.com/scalameta/moped/issues/18
   override val temporaryDirectory: DirectoryFixture =
     new DirectoryFixture {
@@ -41,7 +59,7 @@ abstract class BaseBuildToolSuite extends MopedSuite(LsifJava.app) {
       expectedPackages: String = "",
       initCommand: => List[String] = Nil
   ): Unit = {
-    test(options) {
+    test(options.withTags(options.tags ++ tags)) {
       if (initCommand.nonEmpty) {
         os.proc(Shellable(initCommand)).call(os.Path(workingDirectory))
       }

tests/buildTools/src/test/scala/tests/LsifBuildToolSuite.scala

@@ -3,6 +3,7 @@ package tests
 import com.sourcegraph.lsif_java.{BuildInfo => V}
 
 class LsifBuildToolSuite extends BaseBuildToolSuite {
+  override def tags = List(SkipWindows)
   checkBuild(
     "basic",
     """|/lsif-java.json

tests/buildTools/src/test/scala/tests/MavenBuildToolSuite.scala

@@ -3,6 +3,7 @@ package tests
 import scala.meta.internal.io.InputStreamIO
 
 class MavenBuildToolSuite extends BaseBuildToolSuite {
+  override def tags = List(SkipWindows)
 
   def pomXml =
     new String(

tests/buildTools/src/test/scala/tests/MissingBuildToolSuite.scala

@@ -1,11 +1,12 @@
 package tests
 
 class MissingBuildToolSuite extends BaseBuildToolSuite {
+
   checkErrorOutput(
     "basic",
     List("index"),
     expectedOutput =
-      s"""|error: No build tool detected in workspace '/workingDirectory'. At the moment, the only supported build tools are: Gradle, Maven, sbt.
+      s"""|error: No build tool detected in workspace '${java.io.File.separator}workingDirectory'. At the moment, the only supported build tools are: Gradle, Maven, sbt.
           |""".stripMargin,
     workingDirectoryLayout = ""
   )

tests/buildTools/src/test/scala/tests/SkipWindows.scala

@@ -0,0 +1,3 @@
+package tests
+
+object SkipWindows extends munit.Tag("SkipWindows")