Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move to Kotlin Multiplatform (#230)" #255

Merged
merged 6 commits into from
Sep 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions build-logic/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
plugins {
`kotlin-dsl`
}

dependencies {
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:${libs.versions.kotlin.get()}")
}
9 changes: 8 additions & 1 deletion build-logic/src/main/kotlin/jagr-publish.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
import java.net.URI

plugins {
java
`maven-publish`
}

extensions.configure<JavaPluginExtension> {
withJavadocJar()
withSourcesJar()
}

extensions.configure<PublishingExtension> {
repositories {
maven {
Expand All @@ -16,7 +22,8 @@ extensions.configure<PublishingExtension> {
url = URI(if (version.toString().endsWith("SNAPSHOT")) snapshotsRepoUrl else releasesRepoUrl)
}
}
publications.withType<MavenPublication> {
publications.register<MavenPublication>("maven") {
from(components["java"])
pom {
name.set("jagr")
description.set("An automated tool for grading programming assignments")
Expand Down

This file was deleted.

14 changes: 0 additions & 14 deletions build-logic/src/main/kotlin/kotlin-jvm.base-conventions.gradle.kts

This file was deleted.

22 changes: 16 additions & 6 deletions build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import com.github.jengelman.gradle.plugins.shadow.transformers.Log4j2PluginsCacheFileTransformer
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
application
alias(libs.plugins.kotlin.multiplatform)
alias(libs.plugins.kotlin.jvm)
alias(libs.plugins.kotlin.kapt) apply false
alias(libs.plugins.kotlin.serialization) apply false
alias(libs.plugins.shadow)
alias(libs.plugins.style)
id("kotlin-jvm.base-conventions")
}

dependencies {
jvmMainRuntimeOnly(project("jagr-core"))
jvmMainImplementation(project("jagr-launcher"))
jvmMainImplementation(libs.clikt)
runtimeOnly(project("jagr-core"))
implementation(project("jagr-launcher"))
implementation(libs.clikt)
}

application {
Expand Down Expand Up @@ -55,7 +55,6 @@ val projectVersion = file("version").readLines().first()
project.extra["apiVersion"] = projectVersion.replace("\\.[1-9]\\d*-SNAPSHOT|\\.0|\\.\\d*\$".toRegex(), "")

allprojects {
apply(plugin = "org.jetbrains.kotlin.multiplatform")
apply(plugin = "org.sourcegrade.style")

group = "org.sourcegrade"
Expand All @@ -64,4 +63,15 @@ allprojects {
project.findProperty("buildNumber")
?.takeIf { version.toString().contains("SNAPSHOT") }
?.also { version = version.toString().replace("SNAPSHOT", "RC$it") }

tasks {
withType<KotlinCompile> {
kotlinOptions.jvmTarget = "11"
}
withType<JavaCompile> {
options.encoding = "UTF-8"
sourceCompatibility = "11"
targetCompatibility = "11"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,19 @@ import org.gradle.kotlin.dsl.project
* Add a x.y versioned project api dependency to a x.y.z versioned project.
*/
fun DependencyHandler.apiProject(project: Project, path: String) =
addConfiguration("jvmMainApi", project, path)
addConfiguration("api", project, path)

/**
* Add a x.y versioned project implementation dependency to a x.y.z versioned project.
*/
fun DependencyHandler.implementationProject(project: Project, path: String) =
addConfiguration("jvmMainImplementation", project, path)
addConfiguration("implementation", project, path)

/**
* Add a x.y versioned runtimeOnly dependency to a x.y.z versioned project.
*/
fun DependencyHandler.runtimeOnlyProject(project: Project, path: String) =
addConfiguration("jvmMainRuntimeOnly", project, path)
addConfiguration("runtimeOnly", project, path)

/**
* Add a x.y versioned project dependency to a x.y.z versioned project.
Expand Down
20 changes: 10 additions & 10 deletions core/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
plugins {
kotlin("jvm")
kotlin("plugin.serialization")
id("jagr-publish")
id("jagr-sign")
id("kotlin-jvm.base-conventions")
}

dependencies {
jvmMainApi(project(":jagr-launcher"))
jvmMainImplementation(libs.csv)
jvmMainImplementation(libs.asm.util)
jvmMainImplementation(libs.serialization)
jvmMainImplementation(libs.jansi)
jvmMainImplementation(libs.juniversalchardet)
jvmMainImplementation(kotlin("reflect"))
jvmMainImplementation(files("../gradle/wrapper/gradle-wrapper.jar"))
jvmMainRuntimeOnly(libs.apiguardian)
api(project(":jagr-launcher"))
implementation(libs.csv)
implementation(libs.asm.util)
implementation(libs.serialization)
implementation(libs.jansi)
implementation(libs.juniversalchardet)
implementation(kotlin("reflect"))
implementation(files("../gradle/wrapper/gradle-wrapper.jar"))
runtimeOnly(libs.apiguardian)
}
tasks {
test {
Expand Down
File renamed without changes.
12 changes: 6 additions & 6 deletions grader-api/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
plugins {
`java-library`
id("jagr-publish")
id("jagr-sign")
id("kotlin-jvm.base-conventions")
}

tasks {
Expand All @@ -15,9 +15,9 @@ val apiVersion: String by rootProject
version = apiVersion

dependencies {
jvmMainApi(libs.asm.core)
jvmMainApi(libs.guice)
jvmMainApi(libs.logging.api)
jvmMainApi(libs.bundles.junit)
jvmMainImplementation(libs.annotations)
api(libs.asm.core)
api(libs.guice)
api(libs.logging.api)
api(libs.bundles.junit)
implementation(libs.annotations)
}
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ junit = ["junit-core", "junit-engine", "junit-launcher"]
[plugins]
download = "de.undercouch.download:5.5.0"
gradle-publish = "com.gradle.plugin-publish:1.2.1"
kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
kotlin-kapt = { id = "org.jetbrains.kotlin.kapt", version.ref = "kotlin" }
kotlin-multiplatform = { id = "org.jetbrains.kotlin.multiplatform", version.ref = "kotlin" }
kotlin-serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin" }
shadow = { id = "com.github.johnrengelman.shadow", version = "8.1.1" }
style = "org.sourcegrade.style:3.0.0"
17 changes: 8 additions & 9 deletions launcher/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,27 +1,26 @@
import org.sourcegrade.jagr.script.apiProject

plugins {
kotlin("jvm")
kotlin("kapt")
kotlin("plugin.serialization")
id("jagr-publish")
id("jagr-sign")
id("kotlin-jvm.base-conventions")
}

dependencies {
apiProject(project, "jagr-grader-api")
commonMainImplementation(kotlin("reflect"))
jvmMainApi(libs.coroutines)
jvmMainImplementation(libs.configurate.hocon)
jvmMainImplementation(libs.configurate.kotlin)
jvmMainImplementation(libs.annotations)
jvmMainImplementation(libs.serialization)
jvmMainImplementation(libs.logging.core)
api(libs.coroutines)
implementation(kotlin("reflect"))
implementation(libs.configurate.hocon)
implementation(libs.configurate.kotlin)
implementation(libs.annotations)
implementation(libs.serialization)
implementation(libs.logging.core)
kapt(libs.logging.core)
}

tasks {
@Suppress("UnstableApiUsage")
withType<ProcessResources> {
from(rootProject.file("version")) {
into("org/sourcegrade/jagr/")
Expand Down
17 changes: 9 additions & 8 deletions launcher/gradle-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
plugins {
`java-gradle-plugin`
kotlin("plugin.serialization")
alias(libs.plugins.gradle.publish)
alias(libs.plugins.kotlin.jvm)
alias(libs.plugins.kotlin.serialization)
id("jagr-publish")
// signing done by gradle-publish plugin
id("kotlin-jvm.base-conventions")
}

tasks {
Expand All @@ -13,12 +14,12 @@ tasks {
}

dependencies {
jvmMainCompileOnly(gradleKotlinDsl())
jvmMainImplementation(libs.serialization)
jvmMainImplementation(libs.logging.core)
jvmMainImplementation("de.undercouch:gradle-download-task:${libs.plugins.download.get().version}")
jvmMainRuntimeOnly(project(":jagr-core"))
jvmMainImplementation(project(":jagr-launcher"))
implementation(gradleKotlinDsl())
implementation(libs.serialization)
implementation(libs.logging.core)
implementation("de.undercouch:gradle-download-task:${libs.plugins.download.get().version}")
runtimeOnly(project(":jagr-core"))
implementation(project(":jagr-launcher"))
}

gradlePlugin {
Expand Down