Remove rank from contest voting #1959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1213582907Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Deploying with
|
| Latest commit: |
9422741
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ed067e4a.cadet-frontend.pages.dev |
chownces
reviewed
Sep 15, 2021
There was a problem hiding this comment.
sflr! LGTM. Will wait for @YaleChen299 to implement the new leaderboard hiding feature and perform end-to-end testing before merging. shld be ready to merge in a week's time!
YaleChen299
approved these changes
Sep 23, 2021
chownces
added a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Sep 24, 2021
* Remove rank from contest voting * Rename relative_score to final_score Co-authored-by: En Rong <53928333+chownces@users.noreply.github.com> Co-authored-by: Chen Yanyu <39845424+YaleChen299@users.noreply.github.com>
angelsl
pushed a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Sep 30, 2021
* Remove rank from contest voting * Rename relative_score to final_score Co-authored-by: En Rong <53928333+chownces@users.noreply.github.com> Co-authored-by: Chen Yanyu <39845424+YaleChen299@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corresponding frontend fix to remove rank from contest voting. The voting scores are changed to 1 (worst) to 10 (best), compared to the initial ranking of 1 (best) to 10 (worst).
Type of change
How to test
Test with the following backend PR source-academy/backend#823
Checklist