Remove rank from contest voting #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizchow
changed the title
7 tasks
YaleChen299
reviewed
Sep 8, 2021
| @@ -140,7 +140,7 @@ defmodule CadetWeb.AssessmentsHelpers do | |||
| answer: :answer, | |||
| student_name: :student_name | |||
| }), | |||
| "score", | |||
| "relative_score", | |||
There was a problem hiding this comment.
will this be confusing with the score? Is this relative score the computed final score on the leaderboard? Maybe we can name it final_score or something along those line?
|
percentage dropped due to removed parts, no new uncovered lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the concept of rank from contest voting. The scoring for voting is now 1(worst) to 10 (best).
Should be tested with the frontend PR.