Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment info partial handling #334

Merged

Conversation

rainerdema
Copy link
Contributor

@rainerdema rainerdema commented Mar 28, 2023

Summary

Allow each payment method to define how it is displayed on the confirm and thank-you page.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema rainerdema added the enhancement New feature or request label Mar 28, 2023
@rainerdema rainerdema force-pushed the nebulab/rainerd+elia/add-payment-info-partial-handling branch from db6aeb9 to 007b4bc Compare March 28, 2023 11:10
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #334 (402f545) into main (d554de2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   97.06%   97.05%   -0.01%     
==========================================
  Files         185      190       +5     
  Lines        4494     4484      -10     
==========================================
- Hits         4362     4352      -10     
  Misses        132      132              
Impacted Files Coverage Δ
templates/app/helpers/checkout_helper.rb 100.00% <100.00%> (ø)
templates/app/views/orders/_payment_info.html.erb 100.00% <100.00%> (ø)
...ates/app/views/orders/payment_info/_check.html.erb 100.00% <100.00%> (ø)
...es/app/views/orders/payment_info/_default.html.erb 100.00% <100.00%> (ø)
...es/app/views/orders/payment_info/_gateway.html.erb 100.00% <100.00%> (ø)
templates/spec/helpers/checkout_helper_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rainerdema rainerdema force-pushed the nebulab/rainerd+elia/add-payment-info-partial-handling branch from 007b4bc to 6765f7a Compare March 28, 2023 11:24
Allow each payment method to define how it is displayed on the confirm and
thank-you page.

Co-Authored-By: Elia Schito <elia@schito.me>
@rainerdema rainerdema force-pushed the nebulab/rainerd+elia/add-payment-info-partial-handling branch from 6765f7a to 402f545 Compare March 28, 2023 11:25
@rainerdema rainerdema marked this pull request as ready for review March 28, 2023 11:26
@rainerdema rainerdema requested review from elia and kennyadsl March 28, 2023 11:26
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is good to go IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants