Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider alternatives to avoid loading Stripe JS on the thank you page #257

Open
kennyadsl opened this issue Mar 29, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@kennyadsl
Copy link
Member

kennyadsl commented Mar 29, 2023

Desired Behavior

At the moment of writing, we are considering to load the Stripe JS code in the confirm step to be sure that when requested, we can load the 3DSecure page to confirm the order.

We are doing that by using the new payment info partial introduced in solidusio/solidus_starter_frontend#334. But this will render the same partial in the thank you page. We are safe because we are loading the JS conditionally only on the confirm page within that partial, but that's not a practice to encourage: developers could think that the partial is only loaded on the confirm step, and forget about that check, which might have unexpected implications.

@kennyadsl kennyadsl added the enhancement New feature or request label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant