Skip to content

Conversation

@elf-pavlik
Copy link
Member

@elf-pavlik elf-pavlik commented Aug 19, 2025

closes #70

TODO

  • refactor data formatter
  • refactor validations/webid
  • refactor migrations/webid
  • update README

@jeff-zucker
Copy link
Member

I do not approve of "add a command to replace a temporary id with a permanent id". We had previously discussed that this should be applied to new records but that existing records should keep their temporary ids until the new forms are ready. Changing these now will greatly complicate the manual addition of data and AFAIK does nothing to actually make the the data easier to access or edit. Once the new forms are ready, yes then a migration script can be implemented.

@elf-pavlik
Copy link
Member Author

elf-pavlik commented Aug 19, 2025

@jeff-zucker I'm only refactoring here no behavior will change, it is still the same as in #69

TODO you are refering to will be now tracked in #77

@elf-pavlik elf-pavlik marked this pull request as ready for review August 19, 2025 18:44
@elf-pavlik
Copy link
Member Author

Should be ready to go!

Copy link
Member

@jeff-zucker jeff-zucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested but I assume you have, so good to go.

@elf-pavlik elf-pavlik merged commit fb93042 into solid:main Aug 20, 2025
3 checks passed
@elf-pavlik elf-pavlik deleted the cli branch August 20, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up data scripts

2 participants