Skip to content

Conversation

@elf-pavlik
Copy link
Member

@elf-pavlik elf-pavlik commented Aug 1, 2025

As discussed in #16 and matrix chat. This PR includes in separate commits:

  • added migration script
  • migrated data
  • added validation script to ensure id always equals webid

I will create a separate issue to refactor scripts handling data since it starts getting messy and could use some DRY #70

There was a duplicate record:

cdata:Pat_McBennett a ex:Person ;
  ex:landingPage <https://github.com/pmcb55> ;
  ex:name "Pat McBennett" ;
  ex:webid <https://pmcb55.inrupt.net/profile/card#me> .

cdata:Patrick a ex:Person ;
  ex:name "Patrick" ;
  ex:webid <https://pmcb55.inrupt.net/profile/card#me> .

Which got merged using only Pat McBennett name.

@elf-pavlik elf-pavlik requested review from jeff-zucker and jeswr August 1, 2025 21:53
@elf-pavlik elf-pavlik mentioned this pull request Aug 1, 2025
Comment on lines +38 to +40
dataset.delete(quad)
dataset.add(changeSubject(quad, webid))

Copy link
Member Author

@elf-pavlik elf-pavlik Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dataset.delete(quad)
dataset.add(changeSubject(quad, webid))

This could be removed since it will match on subject anyways and be taken care of there.
At the same time it is one-time migration script which has no tests so maybe better not to touch it for such a minor tiding up.

@elf-pavlik elf-pavlik merged commit 9939e75 into solid:main Aug 7, 2025
3 checks passed
@elf-pavlik elf-pavlik deleted the webid branch August 7, 2025 21:06
@elf-pavlik elf-pavlik mentioned this pull request Aug 19, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants