Oracleless ctoken mint and redeem #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkiplet
reviewed
Feb 3, 2022
| @@ -16,7 +16,7 @@ async fn test_success() { | |||
| ); | |||
|
|
|||
| // limit to track compute unit increase | |||
| test.set_bpf_compute_max_units(30_000); | |||
| test.set_bpf_compute_max_units(35_000); | |||
There was a problem hiding this comment.
Is there a way we can assert that the reserve interest has been refreshed in these tests?
|
lgtm |
…ss deposit_obligation_collateral, updated instruction.rs for writable account
nope-finance
force-pushed
the
oracleless_ctoken_mint_and_redeem
branch
from
dc820e7 to
1d2a0b6
Compare
0xkiplet
reviewed
Feb 17, 2022
| @@ -112,4 +127,6 @@ async fn test_success() { | |||
| user_collateral_balance, | |||
| initial_user_collateral_balance - SOL_DEPOSIT_AMOUNT_LAMPORTS | |||
| ); | |||
|
|
|||
| assert!(sol_reserve.liquidity.cumulative_borrow_rate_wads > old_borrow_rate); | |||
0xkiplet
reviewed
Feb 17, 2022
| /// | ||
| /// Accounts expected by this instruction: | ||
| /// | ||
| /// 0. `[writable]` Source collateral token account. | ||
| /// Minted by deposit reserve collateral mint. | ||
| /// $authority can transfer $collateral_amount. | ||
| /// 1. `[writable]` Destination deposit reserve collateral supply SPL Token account. | ||
| /// 2. `[]` Deposit reserve account - refreshed. | ||
| /// 2. `[writable]` Deposit reserve account. |
There was a problem hiding this comment.
Nit: Do we need to make the same comment change for RedeemReserveCollateral given it no longer needs to be refreshed?
There was a problem hiding this comment.
ah yeh prob should change comment (the reserve over there was alright writable so just removing the "refreshed"
0xkiplet
approved these changes
Feb 17, 2022
|
cool gonna merge this and try to test it on beta later today |
nope-finance
added a commit
that referenced
this pull request
Feb 18, 2022
* fix ci solana version (#67) * Update switchboard-program to v0.2.0 (#66) * oracleless repay (#64) * oracleless repay * lint * the easy way * updated test to make sure interest accumulates before repay * remove unused programs (#60) * remove unused programs * slight consisency changes Co-authored-by: ra <RealAwesomeness@users.noreply.github.com> Co-authored-by: Nope X <nope@solend.fi> * Oracleless ctoken mint and redeem (#69) * no need to refresh on mint/redeem * test fixes * added more robust tests to make sure interest accrues, added oracleless deposit_obligation_collateral, updated instruction.rs for writable account * comment change Co-authored-by: 0xkiplet <98113383+0xkiplet@users.noreply.github.com> Co-authored-by: ra <40503841+RealAwesomeness@users.noreply.github.com> Co-authored-by: ra <RealAwesomeness@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.