remove unused programs #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nope-finance
reviewed
Feb 1, 2022
token-lending/cli/Cargo.toml
Outdated
| spl-token-lending = { path="../program", features = [ "no-entrypoint" ] } | ||
| spl-token = { path="../../token/program", features = [ "no-entrypoint" ] } | ||
| spl-token = "=3.2.0" |
There was a problem hiding this comment.
deleted the token program from the repo
pinned spl-token to v3.2.0
There was a problem hiding this comment.
y not 3.3 i mean and why remove feature
nope-finance
reviewed
Feb 1, 2022
nope-finance
reviewed
Feb 1, 2022
token-lending/program/Cargo.toml
Outdated
| spl-token = { path = "../../token/program", features = [ "no-entrypoint" ] } | ||
| switchboard-program = "0.1.45" | ||
| solana-program = "=1.7.12" | ||
| spl-token = { version = "3.1.0", features=["no-entrypoint"] } |
There was a problem hiding this comment.
um yea sure can do ig
was messing around with the spl-token version to figure out what was the breaking change
nope-finance
force-pushed
the
remove-unused
branch
from
a5ecfba to
d12eb2c
Compare
RadiantAeon
force-pushed
the
remove-unused
branch
from
d12eb2c to
a5ecfba
Compare
nope-finance
force-pushed
the
remove-unused
branch
from
a5ecfba to
710031d
Compare
DaSichuan
reviewed
Feb 2, 2022
| @@ -26,7 +26,7 @@ async fn test_success() { | |||
| ); | |||
|
|
|||
| // limit to track compute unit increase | |||
| test.set_bpf_compute_max_units(3_000); | |||
| test.set_bpf_compute_max_units(4_000); | |||
|
solana version update slightly different compute calculations i guess.
…On Tue, Feb 1, 2022, 4:03 PM Da Sichuan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In token-lending/program/tests/set_lending_market_owner.rs
<#60 (comment)>
:
> @@ -26,7 +26,7 @@ async fn test_success() {
);
// limit to track compute unit increase
- test.set_bpf_compute_max_units(3_000);
+ test.set_bpf_compute_max_units(4_000);
lol why did this need to change?
—
Reply to this email directly, view it on GitHub
<#60 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT5EXXT4Q4QU7QUBH6VBRP3UZBYEFANCNFSM5MSMLVQA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***
com>
|
|
This seems fine to me. Removing unused programs and pinning dependencies. I guess the |
nope-finance
added a commit
that referenced
this pull request
Feb 18, 2022
* fix ci solana version (#67) * Update switchboard-program to v0.2.0 (#66) * oracleless repay (#64) * oracleless repay * lint * the easy way * updated test to make sure interest accumulates before repay * remove unused programs (#60) * remove unused programs * slight consisency changes Co-authored-by: ra <RealAwesomeness@users.noreply.github.com> Co-authored-by: Nope X <nope@solend.fi> * Oracleless ctoken mint and redeem (#69) * no need to refresh on mint/redeem * test fixes * added more robust tests to make sure interest accrues, added oracleless deposit_obligation_collateral, updated instruction.rs for writable account * comment change Co-authored-by: 0xkiplet <98113383+0xkiplet@users.noreply.github.com> Co-authored-by: ra <40503841+RealAwesomeness@users.noreply.github.com> Co-authored-by: ra <RealAwesomeness@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.