Themes: Retain filters and query string when activating (Automattic#1…

…3508)
solarsoft0 · May 1, 2017 · da71c76 · da71c76
1 parent c0194f0
commit da71c76
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/client/my-sites/theme/controller.jsx b/client/my-sites/theme/controller.jsx
@@ -59,7 +59,8 @@ export function details( context, next ) {
 	}
 
 	context.primary = <ThemeSheetComponent id={ slug }
-		section={ section } />;
+		section={ section }
+		pathName={ context.pathname } />;
 	context.secondary = null; // When we're logged in, we need to remove the sidebar.
 	next();
 }

diff --git a/client/my-sites/theme/main.jsx b/client/my-sites/theme/main.jsx
@@ -583,8 +583,7 @@ const ConnectedThemeSheet = connectOptions(
 		}
 
 		return (
-			<ThemesSiteSelectorModal { ...props }
-				sourcePath={ `/theme/${ props.id }${ props.section ? '/' + props.section : '' }` }>
+			<ThemesSiteSelectorModal { ...props }>
 				<ThemeSheet />
 			</ThemesSiteSelectorModal>
 		);

diff --git a/client/my-sites/themes/multi-site.jsx b/client/my-sites/themes/multi-site.jsx
@@ -15,7 +15,7 @@ const MultiSiteThemeShowcase = connectOptions(
 	( props ) => (
 		<div>
 			<SidebarNavigation />
-			<ThemesSiteSelectorModal { ...props } sourcePath="/themes">
+			<ThemesSiteSelectorModal { ...props }>
 				<ThemeShowcase
 					source="showcase"
 					showUploadButton={ false } />

diff --git a/client/my-sites/themes/themes-site-selector-modal.jsx b/client/my-sites/themes/themes-site-selector-modal.jsx
@@ -30,7 +30,7 @@ const ThemesSiteSelectorModal = React.createClass( {
 		defaultOption: OPTION_SHAPE,
 		secondaryOption: OPTION_SHAPE,
 		// Will be prepended to site slug for a redirect on selection
-		sourcePath: PropTypes.string.isRequired,
+		pathName: PropTypes.string.isRequired,
 	},
 
 	getInitialState() {
@@ -43,9 +43,15 @@ const ThemesSiteSelectorModal = React.createClass( {
 	trackAndCallAction( site ) {
 		const action = this.state.selectedOption.action;
 		const themeId = this.state.selectedThemeId;
+		const { search } = this.props;
+
+		let redirectTarget = this.props.pathName + '/' + site.slug;
+		if ( search ) {
+			redirectTarget += '?s=' + search;
+		}
 
 		trackClick( 'site selector', this.props.name );
-		page( this.props.sourcePath + '/' + site.slug );
+		page( redirectTarget );
 
 		/**
 		 * Since this implies a route change, defer it in case other state