Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: Retain filters and query string when activating #13508

Merged
merged 1 commit into from
May 1, 2017

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Apr 28, 2017

Previously, when activating a theme in multi-site mode, you'd be taken to the showcase's single-site mode for the site you'd select -- but any filters and search strings would be lost.

This PR retains them. It does so by passing on the full pathName from the controller, and using that to build the redirect target.

To test:

  • Verify that the above is true.
  • Make sure that activation still works from the theme sheet.

(This started as an attempted fix for #13506 -- however, that issue isn't fixed by this PR.)

@ockham ockham added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 28, 2017
@ockham ockham self-assigned this Apr 28, 2017
@matticbot
Copy link
Contributor

matticbot commented Apr 28, 2017

@matticbot matticbot added the [Size] S Small sized issue label Apr 28, 2017
@folletto
Copy link
Contributor

folletto commented May 1, 2017

Tested on Chrome:

  1. Activated from All Sites with query strings ✅
  2. Activated from Single Site with query strings ✅
  3. Activated from theme sheet with query strings ✅

To be clear, in (3) above the strings aren't preserved, I was just checking if it still worked.

@ockham ockham merged commit da71c76 into master May 1, 2017
@ockham ockham deleted the update/themes-site-selector-modal-path branch May 1, 2017 12:49
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Size] S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants