Skip to content

26 update key setup system #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soham2560 merged 2 commits into from
Jun 6, 2025
Merged

26 update key setup system #27

soham2560 merged 2 commits into from
Jun 6, 2025

Conversation

@rtarun1
Copy link
Collaborator

@rtarun1 rtarun1 commented Jun 4, 2025

Brief

  • ROS's keys expired on June 1st so changed the way key is setup, according to official OSRF Dockerfiles
  • Not sure why by for humble they have explicitly mentioned the key version, but not for noetic. Refer OSRF Dockerfile
  • Tested both the image are building.

@rtarun1 rtarun1 linked an issue Jun 4, 2025 that may be closed by this pull request
Update key setup system #26
Closed
@rtarun1 rtarun1 requested a review from soham2560 June 4, 2025 16:43
@soham2560 soham2560 added the bug Something isn't working label Jun 6, 2025
@soham2560
Copy link
Owner

soham2560 commented Jun 6, 2025 •
edited
Loading

LGTM! thanks for the bug fix! will build and push

@soham2560 soham2560 merged commit c156987 into main Jun 6, 2025
@soham2560 soham2560 deleted the 26-update-key-setup-system branch June 7, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soham2560 soham2560 Awaiting requested review from soham2560

Assignees

@rtarun1 rtarun1

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update key setup system

3 participants

@rtarun1 @soham2560