-
Notifications
You must be signed in to change notification settings - Fork 0
[MPT-14049] Added audit event types endpoints #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,15 @@ | ||
| from mpt_api_client.resources.audit import AsyncAudit, Audit | ||
| from mpt_api_client.resources.billing import AsyncBilling, Billing | ||
| from mpt_api_client.resources.catalog import AsyncCatalog, Catalog | ||
| from mpt_api_client.resources.commerce import AsyncCommerce, Commerce | ||
|
|
||
| __all__ = ["AsyncCatalog", "AsyncCommerce", "Catalog", "Commerce"] # noqa: WPS410 | ||
| __all__ = [ # noqa: WPS410 | ||
| "AsyncAudit", | ||
| "AsyncBilling", | ||
| "AsyncCatalog", | ||
| "AsyncCommerce", | ||
| "Audit", | ||
| "Billing", | ||
| "Catalog", | ||
| "Commerce", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| from mpt_api_client.resources.audit.audit import AsyncAudit, Audit | ||
|
|
||
| __all__ = ["AsyncAudit", "Audit"] # noqa: WPS410 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| from mpt_api_client.http import AsyncService, Service | ||
| from mpt_api_client.http.mixins import ( | ||
| AsyncUpdateMixin, | ||
| UpdateMixin, | ||
| ) | ||
| from mpt_api_client.models import Model | ||
|
|
||
|
|
||
| class EventType(Model): | ||
| """Event Type resource.""" | ||
|
|
||
|
|
||
| class EventTypesServiceConfig: | ||
| """Event Types service configuration.""" | ||
|
|
||
| _endpoint = "/public/v1/audit/event-types" | ||
| _model_class = EventType | ||
| _collection_key = "data" | ||
|
|
||
|
|
||
| class EventTypesService(UpdateMixin[EventType], Service[EventType], EventTypesServiceConfig): | ||
| """Event Types service.""" | ||
|
|
||
|
|
||
| class AsyncEventTypesService( | ||
| AsyncUpdateMixin[EventType], AsyncService[EventType], EventTypesServiceConfig | ||
| ): | ||
| """Async Event Types service.""" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| from mpt_api_client.resources.billing.billing import AsyncBilling, Billing | ||
|
|
||
| __all__ = ["AsyncBilling", "Billing"] # noqa: WPS410 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import pytest | ||
|
|
||
| from mpt_api_client.resources.audit.event_types import AsyncEventTypesService, EventTypesService | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def event_types_service(http_client): | ||
| return EventTypesService(http_client=http_client) | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def async_event_types_service(async_http_client): | ||
| return AsyncEventTypesService(http_client=async_http_client) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("method", ["get", "update"]) | ||
| def test_mixins_present(event_types_service, method): | ||
| assert hasattr(event_types_service, method) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("method", ["get", "update"]) | ||
| def test_async_mixins_present(async_event_types_service, method): | ||
| assert hasattr(async_event_types_service, method) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is better to make the test parametrized instead of multiple asserts :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can update this test on my next PR. I'm adding Accounts, so I can make this parametrized when I update this test. Have to update it anyway.