Skip to content

Conversation

@robcsegal
Copy link
Contributor

Added audit event types endpoints
https://softwareone.atlassian.net/browse/MPT-14049

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

✅ Found Jira issue key in the title: MPT-14049

Generated by 🚫 dangerJS against 39be8b9

@albertsola
Copy link
Contributor

Reviewing the code I just noticed the modules are not being added to the mpt_client like for example commerce:

mpt_api_client/resources/commerce/commerce.py

mpt_api_client/mpt_client.py:43

@robcsegal robcsegal force-pushed the MPT-14049-add-audit-event-types-endpoints branch from aced284 to 39be8b9 Compare October 1, 2025 13:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

@robcsegal
Copy link
Contributor Author

Reviewing the code I just noticed the modules are not being added to the mpt_client like for example commerce:

mpt_api_client/resources/commerce/commerce.py

mpt_api_client/mpt_client.py:43

Pushed an update

@d3rky d3rky merged commit 7ecc4f0 into main Oct 1, 2025
4 checks passed

def test_async_mpt_client() -> None:
mpt = AsyncMPTClient.from_config(base_url=API_URL, api_token=API_TOKEN)
commerce = mpt.commerce
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is better to make the test parametrized instead of multiple asserts :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is better to make the test parametrized instead of multiple asserts :-)

I can update this test on my next PR. I'm adding Accounts, so I can make this parametrized when I update this test. Have to update it anyway.

@d3rky d3rky deleted the MPT-14049-add-audit-event-types-endpoints branch October 1, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants