-
Notifications
You must be signed in to change notification settings - Fork 0
[MPT-14049] Added audit event types endpoints #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Reviewing the code I just noticed the modules are not being added to the mpt_client like for example commerce: mpt_api_client/resources/commerce/commerce.py mpt_api_client/mpt_client.py:43 |
aced284 to
39be8b9
Compare
|
Pushed an update |
|
|
||
| def test_async_mpt_client() -> None: | ||
| mpt = AsyncMPTClient.from_config(base_url=API_URL, api_token=API_TOKEN) | ||
| commerce = mpt.commerce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is better to make the test parametrized instead of multiple asserts :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is better to make the test parametrized instead of multiple asserts :-)
I can update this test on my next PR. I'm adding Accounts, so I can make this parametrized when I update this test. Have to update it anyway.



Added audit event types endpoints
https://softwareone.atlassian.net/browse/MPT-14049