Add conversion traits between Felt and StorageKey#130
Merged
franciszekjob merged 1 commit intosoftware-mansion:sequencer-future-compatfrom Apr 8, 2026
Conversation
AvivYossef-starkware
force-pushed
the
add-storage-key-felt-conversion
branch
3 times, most recently
from
79dc1b3 to
4b0d913
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AvivYossef-starkware
force-pushed
the
add-storage-key-felt-conversion
branch
from
4b0d913 to
7188899
Compare
AvivYossef-starkware
changed the base branch from
master
to
sequencer-future-compat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From<Felt> for StorageKey— formats as0x-prefixed lowercase hexTryFrom<&StorageKey> for Felt— parses the hex string back into aFeltDepends on #129 (starknet-types-core 1.0.0 upgrade).
Test plan
test_storage_key_from_felt— round-trip from Felt to StorageKeytest_felt_try_from_storage_key— round-trip from StorageKey to Felttest_felt_try_from_storage_key_invalid— invalid hex returns error🤖 Generated with Claude Code