Upgrade starknet-types-core from 0.2.4 to 1.0.0#129
Merged
franciszekjob merged 1 commit intosoftware-mansion:masterfrom Mar 30, 2026
Merged
Conversation
Contributor
franciszekjob
left a comment
franciszekjob
left a comment
There was a problem hiding this comment.
Hey @AvivYossef-starkware , thanks for the PR! Let's mention the dependency bump in CHANGELOG.md.
AvivYossef-starkware
force-pushed
the
upgrade-starknet-types-core-1.0.0
branch
from
b20af66 to
e31d92f
Compare
Contributor
Author
|
franciszekjob
requested changes
Mar 30, 2026
- Rename `from_hex_unchecked` to `from_hex_unwrap` across the codebase (API rename in 1.0.0) - Use `Felt::from_hex().unwrap()` where runtime strings are passed (ecdsa test) - Apply rustfmt adjustments from shorter method name - Update CHANGELOG.md Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AvivYossef-starkware
force-pushed
the
upgrade-starknet-types-core-1.0.0
branch
from
e31d92f to
3385f9f
Compare
4 tasks
franciszekjob
approved these changes
Mar 30, 2026
franciszekjob
merged commit 339ae32
into
software-mansion:master
33 of 81 checks passed
franciszekjob
added a commit
that referenced
this pull request
Mar 31, 2026
This reverts commit 339ae32.
franciszekjob
added a commit
that referenced
this pull request
Mar 31, 2026
AvivYossef-starkware
added a commit
to AvivYossef-starkware/starknet-rust
that referenced
this pull request
Apr 8, 2026
…nsion#129)" (software-mansion#133) This reverts commit fe79914.
franciszekjob
pushed a commit
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
starknet-types-coredependency from=0.2.4to=1.0.0Felt::from_hex_unchecked→Felt::from_hex_unwrapacross the codebase (API rename in 1.0.0)Felt::from_hex().unwrap()where runtime strings are passed (ecdsa.rstest)Test plan
cargo build --allcompiles cleanlycargo lint(clippy) passes with no warningscargo fmt --all -- --checkpassescargo build -p starknet-rust-crypto --no-default-features(no_std) buildscargo build -p starknet-rust-crypto --no-default-features --features allocbuildscargo test --all— all test failures are pre-existing (network timeouts, stale version assertions)🤖 Generated with Claude Code