[android] fix ripple effect after #3742 #3781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
approved these changes
Oct 29, 2025
j-piasecki
pushed a commit
that referenced
this pull request
Nov 3, 2025
## Description In #3742 I accidentally broke ripple effect, it starts from point of previous click instead of current (first one starts from the middle). # Diagnosis and cure This is because I added a call to `setPressed` in `canBegin`, which activates the effect before it knows where to start. I added those to make sure `setPressed` is called somewhere, but after some testing I think it is not necessary. ## Test plan <!-- Describe how did you test this change here. -->
j-piasecki
pushed a commit
that referenced
this pull request
Nov 20, 2025
## Description In #3742 I accidentally broke ripple effect, it starts from point of previous click instead of current (first one starts from the middle). # Diagnosis and cure This is because I added a call to `setPressed` in `canBegin`, which activates the effect before it knows where to start. I added those to make sure `setPressed` is called somewhere, but after some testing I think it is not necessary. ## Test plan <!-- Describe how did you test this change here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #3742 I accidentally broke ripple effect, it starts from point of previous click instead of current (first one starts from the middle).
Diagnosis and cure
This is because I added a call to
setPressedincanBegin, which activates the effect before it knows where to start. I added those to make suresetPressedis called somewhere, but after some testing I think it is not necessary.Test plan