Skip to content

Commit 77be5a1

Browse files
akwasniewskij-piasecki
authored andcommitted
[android] fix ripple effect after #3742 (#3781)
## Description In #3742 I accidentally broke ripple effect, it starts from point of previous click instead of current (first one starts from the middle). # Diagnosis and cure This is because I added a call to `setPressed` in `canBegin`, which activates the effect before it knows where to start. I added those to make sure `setPressed` is called somewhere, but after some testing I think it is not necessary. ## Test plan <!-- Describe how did you test this change here. -->
1 parent d2a3232 commit 77be5a1

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -440,9 +440,6 @@ class RNGestureHandlerButtonViewManager :
440440
val isResponder = tryGrabbingResponder()
441441
if (isResponder) {
442442
isTouched = true
443-
// when setPressed(true) is called before canBegin it will not call super.setPressed
444-
// in this case we call it here
445-
setPressed(true)
446443
}
447444

448445
return isResponder

0 commit comments

Comments
 (0)