Refactor: add tracing manager genserver#588
Merged
Conversation
hhubert6
reviewed
Jul 15, 2025
lib/live_debugger_refactor/services/callback_tracer/gen_servers/tracing_manager.ex
Outdated
Show resolved
Hide resolved
lib/live_debugger_refactor/services/callback_tracer/gen_servers/tracing_manager.ex
Outdated
Show resolved
Hide resolved
lib/live_debugger_refactor/services/callback_tracer/process/tracer.ex
Outdated
Show resolved
Hide resolved
…acer.ex Co-authored-by: Hubert Kasprzycki <67634024+hhubert6@users.noreply.github.com>
…s/tracing_manager.ex Co-authored-by: Hubert Kasprzycki <67634024+hhubert6@users.noreply.github.com>
…s/tracing_manager.ex Co-authored-by: Hubert Kasprzycki <67634024+hhubert6@users.noreply.github.com>
hhubert6
reviewed
Jul 15, 2025
Contributor
hhubert6
left a comment
hhubert6
left a comment
There was a problem hiding this comment.
What about {Phoenix.LiveView.Diff, :delete_component, 2} trace?
GuzekAlan
reviewed
Jul 15, 2025
lib/live_debugger_refactor/services/callback_tracer/queries/callbacks.ex
Outdated
Show resolved
Hide resolved
lib/live_debugger_refactor/services/callback_tracer/gen_servers/tracing_manager.ex
Outdated
Show resolved
Hide resolved
lib/live_debugger_refactor/services/callback_tracer/gen_servers/tracing_manager.ex
Outdated
Show resolved
Hide resolved
GuzekAlan
approved these changes
Jul 16, 2025
GuzekAlan
reviewed
Jul 16, 2025
lib/live_debugger_refactor/services/callback_tracer/queries/callbacks.ex
Outdated
Show resolved
Hide resolved
hhubert6
approved these changes
Jul 16, 2025
samrobinsonsauce
pushed a commit
to samrobinsonsauce/live-debugger
that referenced
this pull request
Jul 18, 2025
* Added base for TracingManager * Added callbacks utils * Added callbacks query * Tracing setup * Added process link * Changed directory name from Receivers to GenServers * Added events * Extended bus * Added subscription to bus * Proper handling in tracing manger events * Extracted some code * Extracted tracer function * Updated tracing manager * Added test case * Added tests for queries * Cleanup * Removed comments * Removed dbgs * Removed TODO * Added GenServer tests * Added config checks * Update lib/live_debugger_refactor/services/callback_tracer/process/tracer.ex Co-authored-by: Hubert Kasprzycki <67634024+hhubert6@users.noreply.github.com> * Update lib/live_debugger_refactor/services/callback_tracer/gen_servers/tracing_manager.ex Co-authored-by: Hubert Kasprzycki <67634024+hhubert6@users.noreply.github.com> * Update lib/live_debugger_refactor/services/callback_tracer/gen_servers/tracing_manager.ex Co-authored-by: Hubert Kasprzycki <67634024+hhubert6@users.noreply.github.com> * Deleted tests * Added `SettingsStorage` init * Added `delete_component` trace * CR suggestions * Created actions * Added tests * Changed event names * Moved function to utils --------- Co-authored-by: Hubert Kasprzycki <67634024+hhubert6@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.