Skip to content
This repository was archived by the owner on Aug 29, 2024. It is now read-only.

Conversation

@ioquatix
Copy link
Member

Check if this test actually catch regressions: #70

Types of Changes

  • Maintenance.

Contribution

@ioquatix
Copy link
Member Author

@mintuhouse is there any chance you can make a test for this regression? Because it does not fail even with the previous code.

@mintuhouse
Copy link
Contributor

mintuhouse commented Oct 29, 2023

9d0836e

The test in above commit fails without the fix in 2328451

Might be OS specific as you suspected in #70 (comment)

@mintuhouse
Copy link
Contributor

I am able to reproduce the test failure on devcontainer for ruby 3.2-bookworm

{
	"name": "Ruby",
	"image": "mcr.microsoft.com/devcontainers/ruby:1-3.2-bookworm"
}

@ioquatix
Copy link
Member Author

I think the problem here is trying to create a unix socket on a bind mount filesystem within docker.

@ioquatix
Copy link
Member Author

image

@ioquatix
Copy link
Member Author

image

Both of those running in the docker image. Making IPC in a bind mount is definitely an issue.

@mintuhouse
Copy link
Contributor

Does it mean supervisor may not be working in docker?
Will changing the ipc_path to /tmp/supervisor.ipc help?

@ioquatix
Copy link
Member Author

Yes, I believe using a non-bind-mount path can help, but I don't know about whether IPC doesn't work on a bind mount. If you can test it, try using some of the supervisor commands, e.g. falcon supervisor metrics after using falcon host to start your app.

@ioquatix ioquatix closed this Oct 29, 2023
@mintuhouse
Copy link
Contributor

bundle exec falcon supervisor --path supervisor.sock metrics is working even though ls -al shows s?????????
Thanks for the help

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants