This repository was archived by the owner on Aug 29, 2024. It is now read-only.
Fix for socket file not being reused even when not bound #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my machine, when I `Ctrl+C` (using falcon supervisor), supervisor.ipc remains and when I restart the server, I get EADDRINUSE Found that `File.exist?(@path)` is returning false for such a file even though `ls -al` lists the file Using `FileUtils.safe_unlink` instead of `File.unlink` to safely remove the file when it exists without any error
|
Is it possible we can add some test for this? |
|
I’ll release this tomorrow. |
|
Do you mind letting me know what OS you were running on? |
|
Docker image: |
|
Are you using Docker Desktop? |
|
yes |
|
Okay, I released v1.36.1, do you mind checking it? Thanks :) |
|
Thank you. |
|
Thanks for your report and PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my machine, when I
Ctrl+C(using falcon supervisor), supervisor.ipc remains and when I restart the server, I get EADDRINUSEFound that
File.exist?(@path)is returning false for such a file even thoughls -allists the fileUsing
FileUtils.safe_unlinkinstead ofFile.unlinkto safely remove the file when it exists without any errorTypes of Changes
Contribution