Fix polling transports and add tests for closing transports #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +93,6 @@ Socket.prototype.onPacket = function (packet) { | |||
| break; | |||
|
|
|||
| case 'error': | |||
| this.transport.close(); | |||
There was a problem hiding this comment.
The reason of socket closing becomes "transport close" if we call here.
This method will be called on clearTransport() anyway.
|
We tried running this, but ended up in a situation where the websocket disconnects 30s after an upgrade from xhr-polling. My initial take would be that the event listeners from the old transport are not cleared when the client upgrades and the closeTimeout fires and emits a |
|
Thanks for your report! I will check the problem. |
|
The problem should be fixed now. |
|
Just tested this patch. It's causing reconnects every 30s |
|
@nicofff I just tested with socket.io but it was ok. How can I reproduce? |
rauchg
added a commit
that referenced
this pull request
Nov 18, 2015
Fix polling transports and add tests for closing transports
darrachequesne
pushed a commit
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for #344, #340, #339 and #336.
I have to fix some codes for writing these tests.
upgradingevent on socket