feat: lockfile parser must always return depTree.name
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yuliabaron
changed the title
depTree.namedepTree.name
yuliabaron
changed the title
depTree.namedepTree.name
Kirill89
reviewed
Dec 2, 2018
lib/parsers/index.ts
Outdated
| const manifestFile = JSON.parse(manifestFileContents); | ||
| // Fallback to the file name if name is not set | ||
| if (!manifestFile.name) { | ||
| manifestFile.name = manifestFileName; |
There was a problem hiding this comment.
Can I suggest to move all logic relevant to manifestFileName to /lib/index.ts? Looks like it is not related to parsers because they only need to parse existing file. And also it is less changes (do not need to pass manifestFileName everywhere).
lib/index.ts
Outdated
| @@ -21,7 +21,7 @@ export { | |||
| }; | |||
|
|
|||
| async function buildDepTree( | |||
| manifestFileContents: string, lockFileContents: string, | |||
| manifestFileContents: string, manifestFileName: string, lockFileContents: string, | |||
There was a problem hiding this comment.
Let's maybe make it last argument and make it optional? This way you'll keep API consistent.
yuliabaron
force-pushed
the
feat/lockfile_parser_return_valid_name
branch
from
b2aae05
to
3a9d98a
Compare
Kirill89
approved these changes
Dec 2, 2018
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Dec 3, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
When package name is missing use manifest filename instead
More information
https://snyksec.atlassian.net/browse/SC-6758
Also related to https://github.com/snyk/npm-deps/pull/53 and https://github.com/snyk/registry/pull/6331