fix: move to the new version of nodejs-lockfile-parser #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kirill89
suggested changes
Dec 3, 2018
|
@Kirill89 is right |
yuliabaron
force-pushed
the
lockfile_parser_return_valid_name
branch
2 times, most recently
from
6e4eb50
to
37dcacb
Compare
Kirill89
approved these changes
Dec 5, 2018
|
LGTM. But would ask also @miiila to take a look. |
|
@yuliabaron this is the ticket I was referring to in Boost - would like to bump the version to https://github.com/snyk/nodejs-lockfile-parser/releases/tag/v1.9.1 if you're okay with that |
miiila
suggested changes
Dec 5, 2018
There was a problem hiding this comment.
@yuliabaron I believe this should be a fix commit as we are fixing a bug, when we were not able monitor project without a name. Also wording of a commit could reflect the outcome, as it will be shown in released notes (see https://github.com/snyk/nodejs-lockfile-parser/releases/tag/v1.9.1).
yuliabaron
changed the title
yuliabaron
force-pushed
the
lockfile_parser_return_valid_name
branch
from
37dcacb
to
0387444
Compare
miiila
approved these changes
Dec 5, 2018
|
🎉 This PR is included in version 1.114.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Nov 24, 2020
This was referenced Apr 12, 2022
This was referenced Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Projects with no name property in package.json will now be named by their relative path
What are the relevant tickets?
https://snyksec.atlassian.net/browse/SC-6758
Also related to snyk/nodejs-lockfile-parser#29 and
snyk/npm-deps#53