-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move to the new version of nodejs-lockfile-parser #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need also to pass file name as last argument of parse function.
@Kirill89 is right |
6e4eb50
to
37dcacb
Compare
LGTM. But would ask also @miiila to take a look. |
@yuliabaron this is the ticket I was referring to in Boost - would like to bump the version to https://github.com/snyk/nodejs-lockfile-parser/releases/tag/v1.9.1 if you're okay with that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuliabaron I believe this should be a fix
commit as we are fixing a bug, when we were not able monitor project without a name. Also wording of a commit could reflect the outcome, as it will be shown in released notes (see https://github.com/snyk/nodejs-lockfile-parser/releases/tag/v1.9.1).
37dcacb
to
0387444
Compare
🎉 This PR is included in version 1.114.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
Projects with no name property in package.json will now be named by their relative path
What are the relevant tickets?
https://snyksec.atlassian.net/browse/SC-6758
Also related to snyk/nodejs-lockfile-parser#29 and
snyk/npm-deps#53