Skip to content

feat(language-server): integrate LS #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Team-Hammerhead merged 1 commit into from
May 12, 2025
Merged

feat(language-server): integrate LS #5879

Team-Hammerhead merged 1 commit into from
May 12, 2025

Conversation

@Team-Hammerhead
Copy link
Contributor

@Team-Hammerhead Team-Hammerhead commented May 7, 2025 •
edited by atlassian bot
Loading

Changes since last integration of Language Server

commit 655181e23a1733a9d7d59dc0f71e8bba7f8dc3ec
Author: Knut Funkel <knut.funkel@snyk.io>
Date:   Mon May 12 14:33:22 2025 +0200

    fix: test for unmanaged scans as smoke test [IDE-850] (#868)
    
    fix: run unmnaged scan as smoke test

:100644 100644 d7b47ce7 a54969c9 M	application/server/server_smoke_test.go

commit 960a944441aeed08f92d0841ec4f647fca90b3cf
Author: Knut Funkel <knut.funkel@snyk.io>
Date:   Mon May 12 10:42:33 2025 +0200

    fix: fix unmanaged scan (#865)
    
    * fix: fix unmanaged scan
    
    Make sure parsing of issues does not end prematurly for unmanaged scans.
    We should still parse scanresult even if targetfilepath is empty, since
    unmanaged scans does not have a target file.
    
    * fix: added unit test

:100644 100644 a3c332d9 d7b47ce7 M	application/server/server_smoke_test.go
:100644 100644 5f8c2c5a 317cecd4 M	infrastructure/oss/cli_scanner.go
:100644 100644 bc8f556b bed1998e M	infrastructure/oss/types.go
:100644 100644 85caa463 b319006f M	internal/testsupport/helpers.go

commit 0bbbec2170b2bd3c15f94a7c4d5cbaf5ddd87a85
Author: Ben Durrans <Benjamin.Durrans@snyk.io>
Date:   Fri May 9 14:09:59 2025 +0100

    fix: AI fix applying to the wrong lines [IDE-1096] (#863)
    
    Also added more error state checking.
    Also added more tests for some more complex use cases.
    Added support for edits at the end of the file, including files without a LF at the EOF.

:100644 100644 a76fce49 c3d17309 M	.editorconfig
:100644 100644 bc2845fe 0611fc49 M	domain/ide/command/code_fix_apply_edit.go
:100644 100644 24fe0336 41aa8993 M	infrastructure/code/convert.go
:100644 100644 1616b41a 2fe445ed M	infrastructure/code/convert_test.go
:000000 100644 00000000 ac708fd1 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/01_simple/base_simple_file.txt
:000000 100644 00000000 5626abf0 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/01_simple/corrupt_short_file.txt
:000000 100644 00000000 ce67f762 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/01_simple/good_diff_01.patch
:000000 100644 00000000 4be9c8f6 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/01_simple/malformed_diff_01_hunk_line_format.patch
:000000 100644 00000000 95ce13f7 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/01_simple/malformed_diff_02_hunk_line_numbers.patch
:000000 100644 00000000 0072c1b4 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/02_real_js/base_real_js.js
:000000 100644 00000000 c3584598 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/02_real_js/good_diff_01.patch
:000000 100644 00000000 7809a489 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/03_multi_hunk/base_file.txt
:000000 100644 00000000 b16941fd A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/03_multi_hunk/good_diff_01.patch
:000000 100644 00000000 7b99d53c A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/04_long_diff/base_file.txt
:000000 100644 00000000 7117823f A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/04_long_diff/good_diff_01.patch
:000000 100644 00000000 8a1218a1 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/05_end_of_file/base_file.txt
:000000 100644 00000000 cbe589c3 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/05_end_of_file/good_diff_01_additions.patch
:000000 100644 00000000 c9c6d075 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/05_end_of_file/good_diff_02_deletion_and_additions.patch
:000000 100644 00000000 540e4d1c A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/06_no_lf_at_eof/.editorconfig
:000000 100644 00000000 85954eab A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/06_no_lf_at_eof/base_file.txt
:000000 100644 00000000 dc1f0e30 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/06_no_lf_at_eof/good_diff_01_deletion_mid_file.patch
:000000 100644 00000000 834b7bc2 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/06_no_lf_at_eof/good_diff_02_deletion_adding_lf_at_eof.patch
:000000 100644 00000000 411c7a20 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/06_no_lf_at_eof/good_diff_03_just_adding_lf_at_eof.patch
:000000 100644 00000000 25e7d75d A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/06_no_lf_at_eof/good_diff_04_additions_adding_lf_at_eof.patch
:000000 100644 00000000 9b1d5d8c A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/06_no_lf_at_eof/good_diff_05_additions_keeping_no_lf_at_eof.patch
:000000 100644 00000000 7bceb8f6 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/06_no_lf_at_eof/good_diff_06_deletion_keeping_no_lf_at_eof.patch
:000000 100644 00000000 8a1218a1 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/07_diff_removes_eof_lf/base_file.txt
:000000 100644 00000000 03d8f079 A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/07_diff_removes_eof_lf/good_diff_01_with_additions_at_eof.patch
:000000 100644 00000000 2a423aae A	infrastructure/code/testdata/convert_test/TestCreateAutofixWorkspaceEdit/07_diff_removes_eof_lf/good_diff_02_just_removal_of_eof_lf.patch

commit eaf95932b772b24c3a277c34f279c698d8b25120
Author: Bastian Doetsch <bastian.doetsch@snyk.io>
Date:   Thu May 8 16:17:39 2025 +0200

    chore: add agent rules (#867)
    
    This commit introduces project-specific rules for Windsurf.

:000000 100644 00000000 1d8fe354 A	.windsurfrules

commit b7955460559aa324553a810ad98ebbc55cdaffdc
Author: Bastian Doetsch <bastian.doetsch@snyk.io>
Date:   Thu May 8 15:00:34 2025 +0200

    fix: inline ignores only for vscode [IDE-789] (#866)
    
    * feat: Add tests and fix for code_html feature flags
    
    - Added unit tests for the updateFeatureFlags method in code_html.go to cover scenarios with VS Code and non-VS Code integrations, and when the feature flag is enabled or disabled.
    - Fixed a bug in updateFeatureFlags where the global codeRenderer's inlineIgnoresEnabled field was being updated instead of the instance's field.
    
    * fix: Correct Test_Code_Html_InlineIgnores_Enabled
    
    Set IntegrationName to VS_CODE in Test_Code_Html_InlineIgnores_Enabled
    to ensure the inlineIgnoresEnabled flag is set correctly based on the
    recent logic changes in updateFeatureFlags.

:100644 100644 c8a0234a 21e69a32 M	infrastructure/code/code_html.go
:100644 100644 ed1b43df 93adf85e M	infrastructure/code/code_html_inline_ignores_test.go
:100644 100644 306c6436 f9c84839 M	infrastructure/code/code_html_test.go

commit f0d83ee439fa8f03b6178a6864966e5a9488e0ed
Author: Bastian Doetsch <bastian.doetsch@snyk.io>
Date:   Wed May 7 13:19:45 2025 +0200

    fix: display inline ignores, if feature flag is set (#861)

:100644 100644 e131c7f4 bc2845fe M	domain/ide/command/code_fix_apply_edit.go
:100644 100644 a754c963 41a9108c M	domain/ide/command/code_fix_diffs.go
:100644 100644 f3f279d0 c7e8598c M	domain/ide/command/code_fix_diffs_test.go
:100644 100644 74b61dd8 76c17ddf M	domain/ide/command/code_fix_feedback.go
:100644 100644 6fb60f2e a73966e1 M	domain/ide/command/code_fix_feedback_test.go
:100644 100644 a6ca311b 18b2adbb M	domain/ide/command/command_factory.go
:100644 100644 7072acb7 599c7b08 M	domain/ide/command/generate_issue_description.go
:100644 100644 5e5da7d4 c7ba34c6 M	domain/ide/command/navigate_to_range.go
:100644 100644 1a9ff8ba c8a0234a M	infrastructure/code/code_html.go
:000000 100644 00000000 ed1b43df A	infrastructure/code/code_html_inline_ignores_test.go
:100644 100644 a7a3128c 306c6436 M	infrastructure/code/code_html_test.go
:100644 100644 e9304eed 927a2b8b M	infrastructure/code/code_test.go
:100644 100644 24451009 31ba472e M	infrastructure/code/template/details.html

@Team-Hammerhead Team-Hammerhead requested a review from a team as a code owner May 7, 2025 11:35
@Team-Hammerhead Team-Hammerhead enabled auto-merge May 7, 2025 11:35
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025 •
edited
Loading

Warnings
⚠️

"feat: automatic integration of language server 655181e23a1733a9d7d59dc0f71e8bba7f8dc3ec" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 01f53e3

@team-ide-user team-ide-user force-pushed the feat/automatic-upgrade-of-ls branch 4 times, most recently from d1d6a7c to e65dd7d Compare May 12, 2025 08:57
@team-ide-user team-ide-user force-pushed the feat/automatic-upgrade-of-ls branch from e65dd7d to 01f53e3 Compare May 12, 2025 12:49
@CatalinSnyk CatalinSnyk mentioned this pull request May 12, 2025
Merged
8 tasks
@Team-Hammerhead Team-Hammerhead merged commit 89d59f4 into main May 12, 2025
9 checks passed
@Team-Hammerhead Team-Hammerhead deleted the feat/automatic-upgrade-of-ls branch May 12, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CatalinSnyk CatalinSnyk CatalinSnyk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Team-Hammerhead @CatalinSnyk @team-ide-user