Skip to content

fix: do not traverse node_modules on wizard monitor for yarn #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lili2311 merged 1 commit into from
Oct 11, 2018
Merged

fix: do not traverse node_modules on wizard monitor for yarn #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/cli/commands/protect/wizard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,9 @@ function processAnswers(answers, policy, options) {
// on disk without traversing node_modules
// currently the npm@2 nd npm@3 plugin resolve-deps can do this
// but not the latest node-lockfile-parser
// HACK: if yarn set traverseNodeModules option to
// HACK: for yarn set traverseNodeModules option to true
// bypass lockfile test for wizard
// it is set back to false just before the monitor test
if (targetFile.endsWith('yarn.lock')) {
options.traverseNodeModules = true;
}
Expand Down Expand Up @@ -506,6 +507,17 @@ function processAnswers(answers, policy, options) {
var plugin = plugins.loadPlugin(packageManager);
var info = moduleInfo(plugin, options.policy);

if (targetFile.endsWith('yarn.lock')) {
// TODO: fix this by providing better patch support for yarn
// yarn hoists packages up a tree so we can't assume their location
// on disk without traversing node_modules
// currently the npm@2 nd npm@3 plugin resolve-deps can do this
// but not the latest node-lockfile-parser
// HACK: for yarn set traverseNodeModules option to true
// bypass lockfile test for wizard, but set this back
// before we monitor
options.traverseNodeModules = false;
}
return info.inspect(cwd, targetFile, options)
.then(spinner(lbl))
.then(snyk.monitor.bind(null, cwd, meta))
Expand Down