-
Notifications
You must be signed in to change notification settings - Fork 671
fix: do not traverse node_modules on wizard monitor for yarn #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
849866f to
c4c7b78
Compare
Contributor
|
I think |
c4c7b78 to
8c41db7
Compare
Contributor
Author
|
Thanks I made it myself 🙄 |
miiila
approved these changes
Oct 10, 2018
Contributor
miiila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧙♂️
|
🎉 This PR is included in version 1.103.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixing a bug where if a yarn project is fixed with wizard we traversed the node modules via a specially set flag but then did not set this back just before monitoring.
While traversing node_modules for yarn is a must for now for patching (old style node_module traversal populates where each package lives on disk which is used during patch time) this fall back is not needed for yarn projects node > 6 when we run a test just before monitoring the project & sending the snapshot to snyk web.
Where should the reviewer start?
To replicate:
snyk wizardin theyarn-lockfilesfolder and see the error appear: not a node project (this is an error encountered because we are sending yarn.lock as a filename to theresolve-depslib instead pfpackage.json)