Skip to content

Conversation

@lili2311
Copy link
Contributor

@lili2311 lili2311 commented Oct 9, 2018

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Fixing a bug where if a yarn project is fixed with wizard we traversed the node modules via a specially set flag but then did not set this back just before monitoring.

While traversing node_modules for yarn is a must for now for patching (old style node_module traversal populates where each package lives on disk which is used during patch time) this fall back is not needed for yarn projects node > 6 when we run a test just before monitoring the project & sending the snapshot to snyk web.

Where should the reviewer start?

To replicate:

  • clone https://github.com/lili2311/npm-lockfiles
  • run snyk wizard in the yarn-lockfiles folder and see the error appear: not a node project (this is an error encountered because we are sending yarn.lock as a filename to the resolve-deps lib instead pf package.json)

@lili2311 lili2311 self-assigned this Oct 9, 2018
@darscan
Copy link
Contributor

darscan commented Oct 9, 2018

I think wozard is my new favourite word :)

@lili2311 lili2311 changed the title fix: do not travere node_modules on wozard monitor for yarn fix: do not traverse node_modules on wizard monitor for yarn Oct 9, 2018
@lili2311
Copy link
Contributor Author

lili2311 commented Oct 9, 2018

Thanks I made it myself 🙄

Copy link
Contributor

@miiila miiila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧙‍♂️

@lili2311 lili2311 merged commit f688f5f into master Oct 11, 2018
@lili2311 lili2311 deleted the fix/yarn-wizard branch October 11, 2018 09:31
@snyksec
Copy link

snyksec commented Oct 11, 2018

🎉 This PR is included in version 1.103.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants