Skip to content

Conversation

@krispharper
Copy link

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2688693: The write_pandas function returns invalid value [?] for parameter 'ON_ERROR' instead of actual errors #2638.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Previously, the on_error parameter to the COPY INTO statement in write_pandas was passed via qmark style parameters. If there is an error in the COPY INTO command, instead of the actual error returning to the caller, we get invalid value [?] for parameter 'ON_ERROR'. I.e., there is an error passing the parameter to the statement.

    All other parameters except for table name are passed in via string interpolation, and this PR changes the on_error parameter to be passed via string interpolation as well. After this change, the actual underlying error is passed back to the caller.

  4. (Optional) PR for stored-proc connector:

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNOW-2688693: The write_pandas function returns invalid value [?] for parameter 'ON_ERROR' instead of actual errors

1 participant