SNOW-2688693: fixed on_error parameter passing in write_pandas

krispharper · krispharper · commit 155f11867636 · 2025-11-21T12:22:11.000-05:00
diff --git a/src/snowflake/connector/pandas_tools.py b/src/snowflake/connector/pandas_tools.py
@@ -592,11 +592,10 @@ def drop_object(name: str, object_type: str) -> None:
             f"{' BINARY_AS_TEXT=FALSE' if auto_create_table or overwrite or infer_schema else ''}"
             f"{sql_use_logical_type}"
             f") "
-            f"PURGE=TRUE ON_ERROR=?"
+            f"PURGE=TRUE ON_ERROR='{on_error}'"
         )
         params = (
             target_table_location,
-            on_error,
         )
         logger.debug(f"copying into with '{copy_into_sql}'. params: %s", params)
         copy_results = cursor.execute(

Original file line number	Diff line number	Diff line change
`@@ -592,11 +592,10 @@ def drop_object(name: str, object_type: str) -> None:`
`592`	`592`	`f"{' BINARY_AS_TEXT=FALSE' if auto_create_table or overwrite or infer_schema else ''}"`
`593`	`593`	`f"{sql_use_logical_type}"`
`594`	`594`	`f") "`
`595`		`- f"PURGE=TRUE ON_ERROR=?"`
	`595`	`+ f"PURGE=TRUE ON_ERROR='{on_error}'"`
`596`	`596`	`)`
`597`	`597`	`params = (`
`598`	`598`	`target_table_location,`
`599`		`- on_error,`
`600`	`599`	`)`
`601`	`600`	`logger.debug(f"copying into with '{copy_into_sql}'. params: %s", params)`
`602`	`601`	`copy_results = cursor.execute(`