Removed post-install-cmd php artisan optimize. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to fail due to lack of required config (mail.php)
|
I don't actually understand why this would happen though - the install command is run after you should have set up your mail config. |
snipe
added a commit
that referenced
this pull request
Nov 29, 2013
Removed post-install-cmd php artisan optimize.
|
Per the readme, you're doing a composer install before you config your mail and database to pull down dependancies. |
|
Yeah, I realized that after I asked the question :P It's merged. |
2 tasks
2 tasks
2 tasks
2 tasks
This was referenced Oct 25, 2016
2 tasks
2 tasks
Closed
2 tasks
2 tasks
Closed
Closed
ghost
mentioned this pull request
2 tasks
2 tasks
2 tasks
2 tasks
2 tasks
2 tasks
2 tasks
Closed
1 task
2 tasks
Open
2 tasks
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causes initial install to fail due to lack of required config (mail.php).