Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema validation #3

Closed
23 tasks done
snarfed opened this issue Sep 19, 2023 · 4 comments
Closed
23 tasks done

Schema validation #3

snarfed opened this issue Sep 19, 2023 · 4 comments
Labels
now

Comments

@snarfed
Copy link
Owner

snarfed commented Sep 19, 2023 •
edited
Loading

In progress in the schema-validation branch.

https://atproto.com/specs/lexicon

TODO:

  • nullable
  • array
  • bytes
  • blob
  • ref
  • union
  • const
  • [ ] default
  • string formats:
    • at-identifier
    • at-uri
    • cid
    • datetime
    • did
    • handle
    • nsid
    • tid
    • record-key
    • uri
    • language
  • int:
    • minimum
    • maximum
    • enum
  • array, bytes:
    • minLength
    • maxLength
@snarfed
Copy link
Owner Author

snarfed commented Jan 27, 2024

Current status: debating whether to try to shoehorn JSON Schema into this or just do it all myself.

@snarfed
Copy link
Owner Author

snarfed commented Mar 16, 2024

Bluesky team leans toward doing it from scratch, not via hacked JSON Schema: bluesky-social/atproto#2102 (comment)

@snarfed snarfed changed the title Finish schema validation Schema validation Jul 10, 2024
@snarfed snarfed added the now label Jul 10, 2024
@snarfed
Copy link
Owner Author

snarfed commented Jul 10, 2024

Started on this in the schema validation branch.

snarfed added a commit that referenced this issue Sep 22, 2024
@snarfed
start on schema validation
166a06a 
for #3
snarfed added a commit that referenced this issue Sep 22, 2024
@snarfed
schema validation: support unknown, null, start on blob
b13f829 
for #3
@snarfed snarfed mentioned this issue Sep 23, 2024
Open
snarfed added a commit that referenced this issue Sep 23, 2024
@snarfed
more on schema validation: blob, object, ref, union, cid-link, more o…
8fb15e6 
…n unknown, token

also add multiformats as a dep

for #3
snarfed added a commit that referenced this issue Sep 24, 2024
@snarfed
more schema validation: minimum/maximum, min/maxLength, enum, const
fe7eeb0 
for #3
snarfed added a commit that referenced this issue Sep 24, 2024
@snarfed
schema validation: refactor error messages, start on truncating with …
63ef5b0 
…graphemes

for #3
snarfed added a commit that referenced this issue Sep 24, 2024
@snarfed
schema validation: union bug fix
ab1214f 
for #3
snarfed added a commit that referenced this issue Sep 24, 2024
@snarfed
schema validation: blob params
9a6f6e5 
for #3
snarfed added a commit that referenced this issue Sep 24, 2024
@snarfed
schema validation: more token/ref handling
f01cf0d 
for #3
snarfed added a commit that referenced this issue Sep 24, 2024
@snarfed
schema validation: start on string formats
855bd11 
for #3
snarfed added a commit that referenced this issue Sep 24, 2024
@snarfed
schema validation: string formats: add at-uri, cid, tid, record-key
826ed9a 
for #3
snarfed added a commit that referenced this issue Sep 24, 2024
@snarfed
schema validation: add datetime string format
bc4d288 
for #3
snarfed added a commit that referenced this issue Sep 24, 2024
@snarfed
schema validation: refactor object blob union ref, fix other tests
2435b90 
for #3
snarfed added a commit that referenced this issue Sep 24, 2024
@snarfed
schema validation: bring back some skipped client and server tests
1cacc66 
for #3
snarfed added a commit that referenced this issue Sep 25, 2024
@snarfed
schema validation: client updates, bring back more tests
b420b08 
for #3
snarfed added a commit that referenced this issue Sep 25, 2024
@snarfed
schema validation: bring back server, flask_server tests
ed5ac51 
for #3
snarfed added a commit that referenced this issue Sep 25, 2024
@snarfed
lexicon validation
7cbe4d9 
for #3
snarfed added a commit that referenced this issue Sep 25, 2024
@snarfed
schema validation: add string format test cases
de88c18 
for #3
snarfed added a commit that referenced this issue Sep 25, 2024
@snarfed
schema validation: lots more string format test cases and tweaks
3d55b59 
for #3
snarfed added a commit that referenced this issue Sep 26, 2024
@snarfed
schema validation: fix more tests
d20d97e 
for #3
snarfed added a commit that referenced this issue Sep 26, 2024
@snarfed
schema validation: add datetime parse (semantic) tests
6a6bbfa 
for #3
snarfed added a commit that referenced this issue Sep 26, 2024
@snarfed
refactor schema validation to handle arrays with object/ref/union ele…
a19cfe4 
…ments

for #3
snarfed added a commit that referenced this issue Sep 26, 2024
@snarfed
schema validation: handle refs, unions, etc inside arrays
220dfb8 
for #3
snarfed added a commit that referenced this issue Sep 27, 2024
@snarfed
schema validation: carry top-level lexicon through, use for fully qua…
7b24473 
…lifying

for #3
@snarfed
Copy link
Owner Author

snarfed commented Sep 27, 2024

Landed in main! And updated granary, bridgy-fed, etc.

@snarfed snarfed closed this as completed Sep 27, 2024
@snarfed snarfed mentioned this issue Sep 28, 2024
Closed
snarfed added a commit to snarfed/bridgy-fed that referenced this issue Sep 28, 2024
@snarfed
ATProto: try turning on schema validation for outgoing records
19b5dd5 
see snarfed/lexrpc#3. I expect this will highlight at least a couple kinds of invalid records that we're currently emitting, eg #1327
snarfed added a commit to snarfed/arroba that referenced this issue Sep 28, 2024
@snarfed
Repo.format_commit: validate records against lexicon schemas
ec4d136 
for snarfed/lexrpc#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snarfed