Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still delivering some reposts of/replies to unbridged posts #1327

Open
snarfed opened this issue Sep 13, 2024 · 4 comments
Open

Still delivering some reposts of/replies to unbridged posts #1327

snarfed opened this issue Sep 13, 2024 · 4 comments

Comments

@snarfed
Copy link
Owner

snarfed commented Sep 13, 2024

Thought we caught all of these, but I guess not, some are still happening. Fortunately they get filtered out on both AP and ATProto because the in-reply-tos and repost-ofs are either blank or can't be resolved, but still.

Fediverse => Bluesky example:

{
  "$type": "app.bsky.feed.repost",
  "createdAt": "2024-07-08T20:26:14.000Z",
  "subject": {
    "cid": "",
    "uri": ""
  }
}

I suspect there one or two similar edge cases for replies, protocol-independent.

@snarfed snarfed added the now label Sep 13, 2024
@qazmlp
Copy link

qazmlp commented Sep 13, 2024

That's a directly …#Public-addressed boost which may be uncommon compared to 'unlisted' ones.

(I.e. it's "to": [ "…#Public" ], "cc": [ "…/followers" ] rather than iirc the other way around.)

@snarfed
Copy link
Owner Author

snarfed commented Sep 23, 2024

snarfed/lexrpc#3 will help here, at least for fediverse => Bluesky.

@snarfed
Copy link
Owner Author

snarfed commented Sep 28, 2024

snarfed added a commit that referenced this issue Sep 28, 2024
see snarfed/lexrpc#3. I expect this will highlight at least a couple kinds of invalid records that we're currently emitting, eg #1327
@snarfed
Copy link
Owner Author

snarfed commented Sep 29, 2024

...specifically, schema validation will stop us from trying to deliver these to Bluesky, but we still need to fix the router logic bug that's generating them in the first place.

@Tamschi Tamschi added bug User-facing breakage and reliability issues within Bridgy Fed. infra and removed bug User-facing breakage and reliability issues within Bridgy Fed. labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants