feat: refactor everything to be async #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneekey23
changed the title
kneekey23
force-pushed
the
feat/async
branch
from
d32bf8b to
f5e3e0b
Compare
wooj2
reviewed
Dec 27, 2021
Packages/ClientRuntime/Sources/Networking/Http/CRT/CRTClientEngine.swift
Show resolved
Hide resolved
Packages/ClientRuntime/Sources/Networking/Http/CRT/CRTClientEngine.swift
Outdated
Show resolved
Hide resolved
Packages/ClientRuntime/Sources/Networking/Http/CRT/CRTClientEngine.swift
Show resolved
Hide resolved
Packages/ClientRuntime/Sources/Networking/Http/CRT/CRTClientEngine.swift
Outdated
Show resolved
Hide resolved
Packages/ClientRuntime/Sources/Networking/Http/Middlewares/LoggerMiddleware.swift
Show resolved
Hide resolved
Packages/ClientRuntime/Tests/MiddlewareTests/MiddlewareStackTests.swift
Outdated
Show resolved
Hide resolved
kneekey23
force-pushed
the
feat/async
branch
2 times, most recently
from
5d67b40 to
186724d
Compare
wooj2
reviewed
Jan 19, 2022
Packages/ClientRuntime/Sources/Networking/Http/CRT/CRTClientEngine.swift
Show resolved
Hide resolved
kneekey23
force-pushed
the
feat/async
branch
2 times, most recently
from
8419193 to
eafac45
Compare
aajtodd
approved these changes
Feb 7, 2022
kneekey23
force-pushed
the
feat/async
branch
from
106de9a to
824fe93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Refactor entire sdk to be async
Corresponding:
awslabs/aws-sdk-swift#497
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.