feat: refactor entire sdk to be async #497
Conversation
kneekey23
force-pushed
the
feat/async
branch
from
5dfbd55 to
669e756
Compare
| val output = MiddlewareShapeUtils.outputSymbol(symbolProvider, model, op) | ||
| val outputError = MiddlewareShapeUtils.outputErrorSymbol(op) | ||
| writer.write("$operationStackName.${middlewareStep.stringValue()}.intercept(position: ${position.stringValue()}, middleware: \$N<\$N, \$N>(${middlewareParamsString()}))", AWSClientRuntimeTypes.Core.RetryerMiddleware, output, outputError) |
There was a problem hiding this comment.
It's interesting that we now need to pass these in -- is this because we are now throwing specific exceptions in the Retryer's implementation?
There was a problem hiding this comment.
previously error type was passed throughout the middleware, now since it doesn't have to be since everything is async throws the middlewares that throw the specific type of error have to know about it thus we have to pass it in as a generic.
|
This PR is blocked by a swift compiler bug on Linux reported here: https://bugs.swift.org/browse/SR-15659 |
AWSClientRuntime/Sources/Auth/CredentialsProviderCRTAdapter.swift
Outdated
Show resolved
Hide resolved
|
Update here for anyone following this PR, apple will do a release end of Jan/early Feb and once that happens, this PR will be merged in and released! https://forums.swift.org/t/development-open-for-swift-5-5-3-for-linux-and-windows/54553 |
kneekey23
force-pushed
the
feat/async
branch
3 times, most recently
from
bb4e525 to
c9349e3
Compare
kneekey23
force-pushed
the
feat/async
branch
2 times, most recently
from
cabcb49 to
570918c
Compare
kneekey23
force-pushed
the
feat/async
branch
from
570918c to
ad99c07
Compare
3 participants
CorrespondingPr:
smithy-lang/smithy-swift#389
Issue #
Closes #497
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.