refactor!: observability API and OTeL provider #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Remove or update existing tracing/observability design. |
I recommend to update, which I believe may help users write their own observability integrations and/or use observability hooks. |
ianbotsf
approved these changes
Jul 7, 2023
| { | ||
| "id": "44708ceb-cc8c-478c-bd35-af82aa79f546", | ||
| "type": "misc", | ||
| "description": "**BREAKING**: Refactor observability API and configuration." |
There was a problem hiding this comment.
Nit: I recommend including a link to the breaking discussion post.
lauzadis
approved these changes
Jul 17, 2023
| public val requestsQueuedDuration: DoubleHistogram = meter.createDoubleHistogram( | ||
| "smithy.client.http.requests.queued_duration", | ||
| "s", | ||
| "The amount of time a requests spent queued waiting to be executed by the HTTP client", |
Comment on lines
+93
to
+96
| attempts++ | ||
| if (attempts > 1) { | ||
| metrics.rpcRetryCount.add(1L, perRpcAttributes, metrics.provider.contextManager.current()) | ||
| } |
There was a problem hiding this comment.
I think this is counting the first attempt as a retry, is that correct?
edit: nvm
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Jul 18, 2023
aajtodd
added a commit
that referenced
this pull request
Mar 11, 2024
* feat: identity API upstream changes (#864) * track upstream codegen changes (#879) * track upstream IdentityProvider and Attributes changes (#881) * add base class for credentials config (#883) BREAKING CHANGE: `CredentialsProvider` method name and signature changed. `signer` property removed from service client config in favor of `authSchemes` override.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
n/a
Description of changes
This is the final PR to main that refactors the observability instrumentation (telemetry) APIs. This also includes an implementation of a
TelemetryProviderbased on OpenTelemetry.Incremental PRs already reviewed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.