Mark TelemetryProvider API experimental #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
reviewed
Jul 7, 2023
| public val contextManager: ContextManager | ||
| } | ||
|
|
||
| @OptIn(ExperimentalApi::class) |
There was a problem hiding this comment.
Question: Shouldn't we opt into this annotation globally the way we do with @InternalApi?
There was a problem hiding this comment.
I decided not to because I wanted to see how far reaching the API becomes. Turns out there weren't that many places that need it.
|
Kudos, SonarCloud Quality Gate passed!
|
ianbotsf
approved these changes
Jul 7, 2023
0marperez
approved these changes
Jul 7, 2023
aajtodd
added a commit
that referenced
this pull request
Jul 7, 2023
aajtodd
added a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
Mark the
TelemetryProviderAPI as experimental and optin where necessary. This explicitly doesn't mark theTelemetryProviderinterface or configuration types as experimental as that would make configuring the SDK itself experimental. Instead we mark every field/method on the interface asExperimental. As we stabilize each telemetry signal implementation we can start to remove the annotation (e.g. once we are happy with metrics and the set of metrics exported we might remove it frommeterProvider).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.