Bugfix/issue 1835 AlertManager File upload fix#1836
Merged
JulianKast merged 13 commits intodevelopfrom Sep 23, 2022
Merged
Conversation
…ciding to add image to AlertRPC
Codecov Report
@@ Coverage Diff @@
## develop #1836 +/- ##
=============================================
+ Coverage 54.04% 54.05% +0.01%
- Complexity 5532 5537 +5
=============================================
Files 562 562
Lines 25821 25869 +48
Branches 3398 3415 +17
=============================================
+ Hits 13954 13983 +29
- Misses 10596 10605 +9
- Partials 1271 1281 +10
|
ChloeMJM
requested changes
Sep 22, 2022
base/src/main/java/com/smartdevicelink/managers/screen/PresentAlertOperation.java
Outdated
Show resolved
Hide resolved
ChloeMJM
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1835
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
Unit Tests
Unit test were updated in PresentAlertOperationTest.
Core Tests
Test sending Alert with Image via ScreenManager and verify that the image correctly appears.
Core version / branch / commit hash / module tested against: Manticore
HMI name / version / branch / commit hash / module tested against: Manticore
Summary
Changed check fileManager.hasUploadedFile to fileManager.fileNeedsUpload.
Changelog
Bug Fixes
CLA