Skip to content

Images not displaying correctly on Alerts sent via AlertManager #1835

@JulianKast

Description

@JulianKast

Bug Summary

Images are not displaying correctly on Alerts sent via AlertManager. That is because in PresentAlertOperation.alertRpc we check hasUploadedFile instead of fileNeedsUploaded

        if (alertView.getIcon() != null && supportsAlertIcon() && !(fileManager.get().hasUploadedFile(alertView.getIcon()))) {
            alert.setAlertIcon(alertView.getIcon().getImageRPC());
        }

When it should be: (remove ! when checking fileManager that it has been uploaded)

        if (alertView.getIcon() != null && supportsAlertIcon() && !fileManager.get().fileNeedsUpload(alertView.getIcon())) {
            alert.setAlertIcon(alertView.getIcon().getImageRPC());
        }

Reproduction Steps

  1. Create AlertView with SdlArtwork
  2. Send AlertView via sdlManger to present alert

Expected Behavior:
Alert should display with the correct image

Observed Behavior:
Alert displayed with place holder image.

Which projects have you seen this bug on?

No response

Android Version(s)

n/a

Android Device(s)

No response

sdl_java_suite Version

5.5.0

Testing Environment(s)

Manticore

Relevant log output

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugA defect in the library

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions