This repository was archived by the owner on Sep 5, 2024. It is now read-only.
[TT-1148] new helpers + various streamlines #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofel
changed the title
Tofel
changed the title
# This is the 1st commit message: print also gas estimation/key split result that's TOML-ready # This is the commit message #2: read keyfile from base64-ed env var or file # This is the commit message #3: fix couple of nil pointers, generate address to satisfy validations when estimating gas, read keyfile either from base64-ed env var or file # This is the commit message #4: fix npe, read root buffer from cmd line, zero ephemeral addresses by default # This is the commit message #5: fix tests, const with keyfile env var # This is the commit message #6: split fund returns and keyfile update
Tofel
force-pushed
the
f_two_convienence_methods
branch
from
33d10c7 to
c31b9be
Compare
skudasov
previously approved these changes
May 15, 2024
skudasov
reviewed
May 15, 2024
| case "gas": | ||
| var cfg *seth.Config | ||
| var pk string | ||
| _, pk, err = seth.NewAddress() |
Collaborator
There was a problem hiding this comment.
We'll clean up this later as agreed. Need to refactor key handling and client struct
skudasov
reviewed
May 15, 2024
| } | ||
| bd, err := c.CalculateSubKeyFunding(10, gasPrice.Int64(), 10) | ||
| require.NoError(t, err, "Error calculating subkey funding") | ||
| err = sethcmd.RunCLI([]string{"seth", "-n", os.Getenv("NETWORK"), "keys", "split", "-a", "10", "-b", "10"}) |
Collaborator
There was a problem hiding this comment.
Should we add docs about -b root key buffer?
skudasov
approved these changes
May 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MustGetRootPrivateKey()than viaclient.PrivateKeys[0]epehemeral_address_numberkey is missing from TOML config we will default to0instead of60URLslice before accessing it via index to avoidindex out of bonds