This repository was archived by the owner on Sep 5, 2024. It is now read-only.
deployed contracts map change #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skudasov
reviewed
Feb 26, 2024
| } | ||
|
|
||
| // ShoulSaveDeployedContractMap returns true if the contract map should be saved (i.e. not a simulated network and functionality is enabled) | ||
| func (c *Config) ShoulSaveDeployedContractMap() bool { |
Collaborator
There was a problem hiding this comment.
We do not include some functionality for simulated networks but we use it all the time with static/real networks, for example keyfile.toml is required if we are not in ephemeral mode. Maybe we can use ephemeral flag for this case too?
It doesn't make sense to save any data for ephemeral networks since we can always run it fast from block zero, but it always makes sense to have as much info as possible with a static network, wdyt? @Tofel
skudasov
approved these changes
Feb 26, 2024
Tofel
added a commit
that referenced
this pull request
May 15, 2024
# This is the 1st commit message: print also gas estimation/key split result that's TOML-ready # This is the commit message #2: read keyfile from base64-ed env var or file # This is the commit message #3: fix couple of nil pointers, generate address to satisfy validations when estimating gas, read keyfile either from base64-ed env var or file # This is the commit message #4: fix npe, read root buffer from cmd line, zero ephemeral addresses by default # This is the commit message #5: fix tests, const with keyfile env var # This is the commit message #6: split fund returns and keyfile update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add switch to control whether deployed contracts addresses should be saved to file