Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set node name as JAID to prevent overwrite #8737

Merged
merged 10 commits into from
Mar 20, 2023
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/develop' into bug/BCF-2132_incor…
…rect_nodes_evm_list_output

# Conflicts:
#	core/web/presenters/starknet_chain.go
  • Loading branch information
george-dorin committed Mar 20, 2023
commit 30853a1198c684185a5320e17c8f568e94c4af71
10 changes: 4 additions & 6 deletions core/web/presenters/starknet_chain.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,9 @@ func (r StarkNetNodeResource) GetName() string {
// NewStarkNetNodeResource returns a new StarkNetNodeResource for node.
func NewStarkNetNodeResource(node db.Node) StarkNetNodeResource {
return StarkNetNodeResource{
JAID: NewJAID(node.Name),
Name: node.Name,
ChainID: node.ChainID,
URL: node.URL,
CreatedAt: node.CreatedAt,
UpdatedAt: node.UpdatedAt,
JAID: NewJAIDInt32(node.ID),
Name: node.Name,
ChainID: node.ChainID,
URL: node.URL,
}
}
You are viewing a condensed version of this merge commit. You can view the full changes here.