Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set node name as JAID to prevent overwrite #8737

Merged
merged 10 commits into from
Mar 20, 2023
Merged

Set node name as JAID to prevent overwrite #8737

merged 10 commits into from
Mar 20, 2023

Conversation

george-dorin
Copy link
Contributor

Nodes were initialized with ID=0 and overwritten when unmarshalling.

https://smartcontract-it.atlassian.net/browse/BCF-2132

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

jmank88
jmank88 previously approved these changes Mar 17, 2023
View reviewed changes
@jmank88
Copy link
Contributor

jmank88 commented Mar 17, 2023

I thought I had rigged up the slice index, but clearly that wouldn't have worked 🤦

@jmank88
Copy link
Contributor

jmank88 commented Mar 17, 2023

Should we include the other chains too while we're at it?

We also return the same type from a few other methods - do those need an update too?

Must the ID be an integer? If string is allowed, then the node name might be simpler to reuse. It is already validated to be unique.

@george-dorin
Copy link
Contributor Author

george-dorin commented Mar 17, 2023 •
edited
Loading

@jmank88

Should we include the other chains too while we're at it?

Yes, other chains exhibit the same behavior added incremental id to them also

Must the ID be an integer? If string is allowed, then the node name might be simpler to reuse. It is already validated to be unique.

Changing the ID from int to string means making changes to chainlink-starknet and chainlink-solana I feel it is not justified at this moment

@george-dorin george-dorin requested a review from jmank88 March 17, 2023 12:40
jmank88
jmank88 previously approved these changes Mar 17, 2023
View reviewed changes
samsondav
samsondav previously requested changes Mar 17, 2023
View reviewed changes
core/chains/evm/config/v2/config.go Outdated Show resolved Hide resolved
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 90%)

See analysis details on SonarQube

@george-dorin george-dorin changed the title Add unique ID to prevent overwrite Set node name as JAID to prevent overwrite Mar 20, 2023
@george-dorin george-dorin merged commit 8ef12e1 into develop Mar 20, 2023
@george-dorin george-dorin deleted the bug/BCF-2132_incorrect_nodes_evm_list_output branch March 20, 2023 12:46
@jmank88 jmank88 mentioned this pull request Mar 20, 2023
Merged
smickovskid pushed a commit that referenced this pull request Mar 23, 2023
@george-dorin @smickovskid
Set node name as JAID to prevent overwrite (#8737)
673588d
@chainchad chainchad mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@jkongie jkongie Awaiting requested review from jkongie

@prashantkumar1982 prashantkumar1982 Awaiting requested review from prashantkumar1982

@samsondav samsondav Awaiting requested review from samsondav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@george-dorin @jmank88 @samsondav