Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPA-1150]: feat(chain): return network data on graphql #14718

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

graham-chainlink
Copy link
Collaborator

@graham-chainlink graham-chainlink commented Oct 10, 2024

Our goal is to allow APTOS chain config to be created on the operator UI. Currently we hardcode EVM as the only support chain on the UI, by returning a list of networks along with the chains, we can allow users to select other networks.

Currently for graphql query chains and chain, they do not support returning network/chain type such as evm, solana, or aptos etc.

For chain and chains graphql query, this commit add support for returning the network associated with the chain.

This can then be used on the operator UI to show a list of supported chains instead of just hardcoded to EVM.

{
    chains{
        results{
            id
            network <---- new
        }
    }
}

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1150

Testing

Screenshot 2024-10-11 at 2 40 29 pm

@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1150/return-network-chain-query branch 2 times, most recently from 2470f28 to ca4e07e Compare October 10, 2024 14:45
Copy link
Contributor

github-actions bot commented Oct 10, 2024

WF: CI Core#36d4d87

No errors found in this run. 🎉

@graham-chainlink graham-chainlink marked this pull request as ready for review October 10, 2024 15:23
@graham-chainlink graham-chainlink requested review from a team as code owners October 10, 2024 15:23
@graham-chainlink graham-chainlink changed the title [DPA-1150]: feat(chain): return network data [DPA-1150]: feat(chain): return network data on graphql Oct 10, 2024
@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1150/return-network-chain-query branch 3 times, most recently from 8f1ad0a to 414b623 Compare October 11, 2024 03:29
Currently for graphql query chains and chain, they do not support returning network/chain type such as evm, solana, or aptos etc.

For `chain` and `chains` graphql query, this commit add support for returning the network associated with the chain.

This can then be used on the operator UI to show a list of supported chains instead of just hardcoded to EVM.

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1150
@graham-chainlink graham-chainlink force-pushed the ggoh/DPA-1150/return-network-chain-query branch from 414b623 to a4e251d Compare October 11, 2024 04:07
@graham-chainlink graham-chainlink requested a review from a team as a code owner October 11, 2024 04:07
@archseer archseer added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@archseer archseer requested a review from a team as a code owner October 14, 2024 08:40
@graham-chainlink
Copy link
Collaborator Author

Please help me merge or add to merge group as I am not authorised

@archseer archseer enabled auto-merge October 14, 2024 10:18
@archseer archseer added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@krehermann krehermann added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit 16499e5 Oct 14, 2024
129 checks passed
@krehermann krehermann deleted the ggoh/DPA-1150/return-network-chain-query branch October 14, 2024 19:59
cedric-cordenier pushed a commit that referenced this pull request Oct 15, 2024
Currently for graphql query chains and chain, they do not support returning network/chain type such as evm, solana, or aptos etc.

For `chain` and `chains` graphql query, this commit add support for returning the network associated with the chain.

This can then be used on the operator UI to show a list of supported chains instead of just hardcoded to EVM.

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1150

Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>
Co-authored-by: Giorgio Gambino <151543+giogam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants