-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPA-1150]: feat(chain): return network data on graphql #14718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graham-chainlink
force-pushed
the
ggoh/DPA-1150/return-network-chain-query
branch
2 times, most recently
from
October 10, 2024 14:45
2470f28
to
ca4e07e
Compare
WF: CI Core#36d4d87No errors found in this run. 🎉 |
graham-chainlink
changed the title
[DPA-1150]: feat(chain): return network data
[DPA-1150]: feat(chain): return network data on graphql
Oct 10, 2024
graham-chainlink
force-pushed
the
ggoh/DPA-1150/return-network-chain-query
branch
3 times, most recently
from
October 11, 2024 03:29
8f1ad0a
to
414b623
Compare
Currently for graphql query chains and chain, they do not support returning network/chain type such as evm, solana, or aptos etc. For `chain` and `chains` graphql query, this commit add support for returning the network associated with the chain. This can then be used on the operator UI to show a list of supported chains instead of just hardcoded to EVM. JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1150
graham-chainlink
force-pushed
the
ggoh/DPA-1150/return-network-chain-query
branch
from
October 11, 2024 04:07
414b623
to
a4e251d
Compare
archseer
approved these changes
Oct 11, 2024
kalverra
approved these changes
Oct 11, 2024
jkongie
approved these changes
Oct 11, 2024
krehermann
approved these changes
Oct 11, 2024
1 task
dimriou
approved these changes
Oct 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2024
giogam
approved these changes
Oct 14, 2024
Please help me merge or add to merge group as I am not authorised |
Quality Gate passedIssues Measures |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2024
cedric-cordenier
pushed a commit
that referenced
this pull request
Oct 15, 2024
Currently for graphql query chains and chain, they do not support returning network/chain type such as evm, solana, or aptos etc. For `chain` and `chains` graphql query, this commit add support for returning the network associated with the chain. This can then be used on the operator UI to show a list of supported chains instead of just hardcoded to EVM. JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1150 Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Giorgio Gambino <151543+giogam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our goal is to allow APTOS chain config to be created on the operator UI. Currently we hardcode EVM as the only support chain on the UI, by returning a list of networks along with the chains, we can allow users to select other networks.
Currently for graphql query chains and chain, they do not support returning network/chain type such as evm, solana, or aptos etc.
For
chain
andchains
graphql query, this commit add support for returning the network associated with the chain.This can then be used on the operator UI to show a list of supported chains instead of just hardcoded to EVM.
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1150
Testing