[DPA-1155]: feat(chainconfig): support aptos #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graham-chainlink
force-pushed
the
ggoh/DPA-1155/support-aptos-chain-config
branch
5 times, most recently
from
e034f3d to
a1205bd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 87.58% 87.68% +0.10%
==========================================
Files 247 249 +2
Lines 4503 4524 +21
Branches 781 735 -46
==========================================
+ Hits 3944 3967 +23
- Misses 537 555 +18
+ Partials 22 2 -20 ☔ View full report in Codecov by Sentry. |
|
Unfortunately with the code coverage complains, just that the the current components are lacking unit tests, it will take some time to add all those missing unit tests, so i only added some for now. |
ChrisAmora
approved these changes
Oct 15, 2024
graham-chainlink
force-pushed
the
ggoh/DPA-1155/support-aptos-chain-config
branch
from
a1205bd to
9db2c15
Compare
Allow APTOS to be selected in the chainconfig modal instead of just EVM JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1155
graham-chainlink
force-pushed
the
ggoh/DPA-1155/support-aptos-chain-config
branch
2 times, most recently
from
e318285 to
e623f73
Compare
|
jkongie
approved these changes
Oct 15, 2024
graham-chainlink
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Oct 15, 2024
Pulling in the latest change to support APTOS in chain config UI Reference: smartcontractkit/operator-ui#90 JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1155
github-merge-queue bot
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Oct 15, 2024
Pulling in the latest change to support APTOS in chain config UI Reference: smartcontractkit/operator-ui#90 JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1155
cedric-cordenier
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Oct 15, 2024
Pulling in the latest change to support APTOS in chain config UI Reference: smartcontractkit/operator-ui#90 JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow APTOS to be selected in the chainconfig modal instead of just EVM.
The goal is being able to support APTOS in core node.
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1155
Pending this PR to be merged for the new
networkfield.Testing
Checklist
If this PR creates changes to the operator-ui itself, rather than tests, pipeline changes, etc. Then please create a changeset so that a new release is created, and the changelog is updated. See: https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md#what-is-a-changeset