Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for wasm file spec workflows, make the config a file instead of hard-coding in the job. #14699

Merged
merged 3 commits into from
Oct 9, 2024
Merged

for wasm file spec workflows, make the config a file instead of hard-coding in the job. #14699

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f9c81c
for wasm file spec workflows, make the config a file instead of hard-…
nolag Oct 9, 2024
b2fc0d3
fix models test
nolag Oct 9, 2024
6994685
Merge branch 'develop' into rtinianov_configAlsoFile
nolag Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix models test
  • Loading branch information
@nolag
nolag committed Oct 9, 2024
commit b2fc0d3e4d657480bf98a2cb5b7e440efd85d4d7
4 changes: 2 additions & 2 deletions core/services/workflows/models_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ targets:
for _, tc := range testCases {
t.Run(tc.name, func(st *testing.T) {

spec, _, _, err := job.YAMLSpecFactory{}.Spec(testutils.Context(t), tc.yaml, nil)
spec, _, _, err := job.YAMLSpecFactory{}.Spec(testutils.Context(t), tc.yaml, "")
require.NoError(t, err)

wf, err := Parse(spec)
Expand Down Expand Up @@ -323,7 +323,7 @@ targets:
}

func TestParsesIntsCorrectly(t *testing.T) {
spec, _, _, err := job.YAMLSpecFactory{}.Spec(testutils.Context(t), hardcodedWorkflow, nil)
spec, _, _, err := job.YAMLSpecFactory{}.Spec(testutils.Context(t), hardcodedWorkflow, "")
require.NoError(t, err)

wf, err := Parse(spec)
Expand Down
Loading