-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for wasm file spec workflows, make the config a file instead of hard-coding in the job. #14699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coding in the job.
WF: CI Core#3f9c81cNo errors found in this run. 🎉 |
cedric-cordenier
previously approved these changes
Oct 9, 2024
vreff
previously approved these changes
Oct 9, 2024
WF: CI Core#b2fc0d3No errors found in this run. 🎉 |
nolag
force-pushed
the
rtinianov_configAlsoFile
branch
from
October 9, 2024 16:17
55022d9
to
b2fc0d3
Compare
cedric-cordenier
approved these changes
Oct 9, 2024
WF: CI Core#6994685No errors found in this run. 🎉 |
vreff
approved these changes
Oct 9, 2024
Quality Gate passedIssues Measures |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this isn't used yet so the breaking change is ok.