Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for wasm file spec workflows, make the config a file instead of hard-coding in the job. #14699

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

nolag
Copy link
Contributor

@nolag nolag commented Oct 9, 2024

Note, this isn't used yet so the breaking change is ok.

@nolag nolag requested a review from a team as a code owner October 9, 2024 14:19
@nolag nolag requested a review from jmank88 October 9, 2024 14:19
Copy link
Contributor

github-actions bot commented Oct 9, 2024

WF: CI Core#3f9c81c

No errors found in this run. 🎉

@nolag nolag enabled auto-merge October 9, 2024 14:22
vreff
vreff previously approved these changes Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

WF: CI Core#b2fc0d3

No errors found in this run. 🎉

@nolag nolag dismissed stale reviews from vreff and cedric-cordenier via b2fc0d3 October 9, 2024 16:17
@nolag nolag force-pushed the rtinianov_configAlsoFile branch from 55022d9 to b2fc0d3 Compare October 9, 2024 16:17
@nolag nolag requested a review from a team as a code owner October 9, 2024 16:17
Copy link
Contributor

github-actions bot commented Oct 9, 2024

WF: CI Core#6994685

No errors found in this run. 🎉

@nolag nolag added this pull request to the merge queue Oct 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2024
@nolag nolag added this pull request to the merge queue Oct 9, 2024
Merged via the queue into develop with commit 4129934 Oct 9, 2024
78 of 81 checks passed
@nolag nolag deleted the rtinianov_configAlsoFile branch October 9, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants