integration-tests/deployment/ccip: fix assertion fns #14482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
commented
Sep 18, 2024
Comment on lines
+200
to
+201
| t.Logf("Waiting for ExecutionStateChanged on chain %d (offramp %s) from chain %d with expected sequence number %d, current onchain minSeqNr: %d, execution state: %s", | ||
| dest.Selector, offRamp.Address().String(), source.Selector, expectedSeqNr, scc.MinSeqNr, executionStateToString(executionState)) |
There was a problem hiding this comment.
Adding these logs to aid in test debugging - in case the log fetching is (for whatever reason) not working.
makramkd
commented
Sep 18, 2024
Comment on lines
+202
to
+206
| if executionState == EXECUTION_STATE_SUCCESS { | ||
| t.Logf("Observed SUCCESS execution state on chain %d (offramp %s) from chain %d with expected sequence number %d", | ||
| dest.Selector, offRamp.Address().String(), source.Selector, expectedSeqNr) | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Adding this because in the flakes I observed the following phenomenon:
2024-09-18T16:35:18.1257108Z Waiting for ExecutionStateChanged on chain 5548718428018410741 (offramp 0x5E6f8839581AfeE68f899bF33B8F284FFf92ef0E) from chain 909606746561742123 with expected sequence number 1, current onchain minSeqNr: 2, execution state: UNTOUCHED
2024-09-18T16:35:18.1258349Z Waiting for ExecutionStateChanged on chain 909606746561742123 (offramp 0xBAa5D0009A5a445ab05F190923dBFd0624BC9dd7) from chain 5548718428018410741 with expected sequence number 1, current onchain minSeqNr: 2, execution state: UNTOUCHED
2024-09-18T16:35:18.1259586Z Waiting for ExecutionStateChanged on chain 5548718428018410741 (offramp 0x5E6f8839581AfeE68f899bF33B8F284FFf92ef0E) from chain 789068866484373046 with expected sequence number 1, current onchain minSeqNr: 2, execution state: SUCCESS
2024-09-18T16:35:18.1260817Z Waiting for ExecutionStateChanged on chain 909606746561742123 (offramp 0xBAa5D0009A5a445ab05F190923dBFd0624BC9dd7) from chain 789068866484373046 with expected sequence number 1, current onchain minSeqNr: 2, execution state: SUCCESS
2024-09-18T16:35:18.1262055Z Waiting for ExecutionStateChanged on chain 789068866484373046 (offramp 0xAF84A0E10C914dD6d91c2e1674031f4668Ada3FB) from chain 909606746561742123 with expected sequence number 1, current onchain minSeqNr: 2, execution state: UNTOUCHED
2024-09-18T16:35:18.1263291Z Waiting for ExecutionStateChanged on chain 789068866484373046 (offramp 0xAF84A0E10C914dD6d91c2e1674031f4668Ada3FB) from chain 5548718428018410741 with expected sequence number 1, current onchain minSeqNr: 2, execution state: UNTOUCHED
i.e even before subscribing it seems that we successfully executed some messages. The subscription never ended up picking up these logs and relaying them to the channel. So this is hopefully going to aid in those cases.
AnieeG
approved these changes
Sep 18, 2024
winder
reviewed
Sep 18, 2024
Comment on lines
+51
to
+52
| ccipocr3.SeqNum(expectedSeqNums[dstChain.Selector]), | ||
| ccipocr3.SeqNum(expectedSeqNums[dstChain.Selector]), |
There was a problem hiding this comment.
Input should probably be expectedSeqNums map[uint64]SeqNumRange since we'll need that eventually.
winder
approved these changes
Sep 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
momentmaker
added a commit
that referenced
this pull request
Sep 19, 2024
* develop: (79 commits) core/config/toml: include value in InsecureConnection error message (#14495) vrf: add soneium config for integration tests (#14443) Add default test config for Grafana (#14475) Update to 1.5 RMN contract address (#14485) fix lint issues (#14450) [BCFR-203] Improve CR value comparator querying (topics and data words) by doing encoding in the relayer (#14207) integration-tests/deployment/ccip: fix assertion fns (#14482) chore: remove gha workflow validation (#14487) devsvcs-244: update token transfer (#14481) DF-20481: Add new OCR3DataFeeds telemetry type for Mercury jobs (#14470) Merc 6304 view function ea telem support (#14467) [DEVSVCS-545] cleanup (#14478) Mantle use vanilla l1 oracle (#14471) Fix E2E_TESTS_ON_GITHUB_CI.md (#14473) Upgrade chainlink ccip dependency (#14474) [DEVSVCS-545] automation benchmark test remove support for keepers v1 (#14472) Enables OOO Execution for E2E Tests (#14392) Delegate workflow spec creation (#14365) CCIP-3407: Add release testing configs (#1436) (#14463) Implement v0.3-compatible telemetry for LLO (#14440) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Resolves