Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vrf: add soneium config for integration tests #14443

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

leeyikjiun
Copy link
Contributor

Requires

Resolves

@leeyikjiun leeyikjiun requested review from ibrajer, iljapavlovs and a team September 16, 2024 16:27
@leeyikjiun leeyikjiun requested a review from a team as a code owner September 16, 2024 16:27
KuphJr
KuphJr previously approved these changes Sep 17, 2024
@@ -0,0 +1,8 @@
[Network]
selected_networks = ["SONEIUM_SEPOLIA"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it actually working? Since its a new network and I dont see it specified in CTF fw

Or other way was to specify it in default.toml config

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, dont forget to add default chain setting like here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually not working. I had to specify the entire [Network.EVMNetworks.SONEIUM_SEPOLIA] in my local config. There's urls, and keys in the config so I'm not committing the changes. For this PR to work, the CTF networks has to be updated like you said.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leeyikjiun you need to put URLS into ~/.testsecrets as per https://github.com/smartcontractkit/chainlink-testing-framework/blob/a1811529658da84a861b4bd966adafe23789f531/lib/config/README.md#test-secrets

Also, recommend a video on this if you have not seen it yet

@leeyikjiun leeyikjiun added this pull request to the merge queue Sep 19, 2024
Merged via the queue into develop with commit ef5b9a7 Sep 19, 2024
136 checks passed
@leeyikjiun leeyikjiun deleted the vrf-add-soneium-config-test branch September 19, 2024 12:43
momentmaker added a commit that referenced this pull request Sep 19, 2024
* develop: (79 commits)
  core/config/toml: include value in InsecureConnection error message (#14495)
  vrf: add soneium config for integration tests (#14443)
  Add default test config for Grafana (#14475)
  Update to 1.5 RMN contract address (#14485)
  fix lint issues (#14450)
  [BCFR-203] Improve CR value comparator querying (topics and data words) by doing encoding in the relayer (#14207)
  integration-tests/deployment/ccip: fix assertion fns (#14482)
  chore: remove gha workflow validation (#14487)
  devsvcs-244: update token transfer (#14481)
  DF-20481: Add new OCR3DataFeeds telemetry type for Mercury jobs (#14470)
  Merc 6304 view function ea telem support (#14467)
  [DEVSVCS-545] cleanup (#14478)
  Mantle use vanilla l1 oracle (#14471)
  Fix E2E_TESTS_ON_GITHUB_CI.md (#14473)
  Upgrade chainlink ccip dependency (#14474)
  [DEVSVCS-545] automation benchmark test remove support for keepers v1 (#14472)
  Enables OOO Execution for E2E Tests (#14392)
  Delegate workflow spec creation (#14365)
  CCIP-3407: Add release testing configs (#1436) (#14463)
  Implement v0.3-compatible telemetry for LLO (#14440)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants