Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multichain keybundle #14369

Merged
merged 28 commits into from
Sep 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
be5d270
Fix multichain adapter
cedric-cordenier Jul 26, 2024
af1a66a
Use more compact binary encoding for multi-chain public key encoding
archseer Sep 4, 2024
1ebf2bd
keystone: Replace transmit function
archseer Aug 27, 2024
cdf8039
keystone: Remove unused beforeSetConfig hook
archseer Aug 27, 2024
53ef01c
keystone: OCR3Capability to store all pubkeys for multi-chain bundles
archseer Aug 30, 2024
182fc0e
keystone: Use custom decoder for OCR3Capability
archseer Aug 30, 2024
d5393af
scripts: keystone: Use the new encoding format for pubkeys
archseer Sep 4, 2024
63a3424
keystone: Merge OCR2Base into OCR3Capability since we already diverged
archseer Sep 4, 2024
015d968
keystone: Fix setConfig typing so typechain bindings actually generate
archseer Sep 4, 2024
5d4e4dc
Use a custom digester and log decoder
archseer Sep 9, 2024
7d013f3
Use multi-chain setup for signing (single-chain won't work anymore)
archseer Aug 1, 2024
8c389ee
Remove stray aptos key bundle
archseer Sep 9, 2024
8a82845
Update test snapshot
archseer Sep 9, 2024
2a84472
remove stray aptos code
archseer Sep 9, 2024
c5ec22a
solhint
archseer Sep 9, 2024
a3e06b3
Add clause for OCR3 capability
cedric-cordenier Sep 9, 2024
192e6ce
bootstrap: Only setup the config provider, not the whole plugin
archseer Sep 9, 2024
f3ef58f
address lints
archseer Sep 9, 2024
fe6f81c
Update test snapshot
archseer Sep 9, 2024
b84065b
check for overflow
archseer Sep 9, 2024
fd7b69d
Use a different config digest prefix for OCR3Capability
archseer Sep 10, 2024
c1af78c
keystone: Remove s_signers, it's unused since we only emit event
archseer Sep 10, 2024
c66da2c
keystone: Remove SetConfigArgs
archseer Sep 10, 2024
a00a132
Update gethwrappers
app-token-issuer-infra-releng[bot] Sep 11, 2024
9dd0732
Update config digest prefix to latest agreed upon value
archseer Sep 17, 2024
c97251d
keystone: Validate uniqueness of all keys inside the multi-chain key …
archseer Sep 17, 2024
0930f22
Update gethwrappers
app-token-issuer-infra-releng[bot] Sep 17, 2024
0042a1b
Fix pruning query
reductionista Sep 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
solhint
  • Loading branch information
archseer committed Sep 17, 2024
commit c5ec22a91bc0082345005b1d11fd596fd8d10a31
2 changes: 2 additions & 0 deletions contracts/src/v0.8/keystone/OCR3Capability.sol
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,10 @@ contract OCR3Capability is ConfirmedOwner, OCR2Abstract {
uint16 len = uint16(publicKeys.length);
// scan through public keys to validate encoded format
while (offset < len) {
// solhint-disable-next-line no-unused-vars
uint8 keyType = uint8(publicKeys[offset]);
uint16 keyLen = uint16(uint8(publicKeys[offset + 1])) + (uint16(uint8(publicKeys[offset + 2])) << 8);
// solhint-disable-next-line no-unused-vars
bytes calldata publicKey = publicKeys[offset + 3:offset + 3 + keyLen];
offset += 3 + keyLen;
}
Expand Down